Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers #10857

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers #10857

merged 1 commit into from
Mar 2, 2023

Conversation

pgorszkowski-igalia
Copy link
Contributor

@pgorszkowski-igalia pgorszkowski-igalia commented Mar 1, 2023 •
edited by webkit-early-warning-system

1506a7b

[GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers
https://bugs.webkit.org/show_bug.cgi?id=253145

Reviewed by Carlos Garcia Campos.

Add missing function: engineeringSettingsAllowed to BrowserInspectorFrontendHost.

It solves a regression from: 2326b11

* Source/WebInspectorUI/UserInterface/Base/BrowserInspectorFrontendHost.js:
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.engineeringSettingsAllowed):

Canonical link: https://commits.webkit.org/261056@main

8607a13

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@pgorszkowski-igalia pgorszkowski-igalia self-assigned this Mar 1, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 270c43c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
⏳ 🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
⏳ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@pgorszkowski-igalia pgorszkowski-igalia added the Web Inspector Bugs related to the WebKit Web Inspector. label Mar 1, 2023
carlosgcampos
carlosgcampos approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@carlosgcampos carlosgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please use the bug title in the commit message too.

@pgorszkowski-igalia pgorszkowski-igalia force-pushed the eng/GTKWPE-Remote-Web-Inspector-the-remote-inspectorHTTP-does-not-work-from-any-browsers branch from 270c43c to 8607a13 Compare March 1, 2023 11:30
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 8607a13)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@pgorszkowski-igalia pgorszkowski-igalia added the request-merge-queue Request a pull request to be added to merge-queue once ready label Mar 2, 2023
@magomez magomez added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Mar 2, 2023
@pgorszkowski-igalia @magomez
[GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not …
1506a7b 
…work from any browsers

https://bugs.webkit.org/show_bug.cgi?id=253145

Reviewed by Carlos Garcia Campos.

Add missing function: engineeringSettingsAllowed to BrowserInspectorFrontendHost.

It solves a regression from: WebKit@2326b11

* Source/WebInspectorUI/UserInterface/Base/BrowserInspectorFrontendHost.js:
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.engineeringSettingsAllowed):

Canonical link: https://commits.webkit.org/261056@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GTKWPE-Remote-Web-Inspector-the-remote-inspectorHTTP-does-not-work-from-any-browsers branch from 8607a13 to 1506a7b Compare March 2, 2023 09:40
@webkit-commit-queue webkit-commit-queue changed the title [GTK][WPE] Web Inspector: fix a problem to use remote inspector from other browsers [GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers Mar 2, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261056@main (1506a7b): https://commits.webkit.org/261056@main

Reviewed commits have been landed. Closing PR #10857 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 1506a7b into WebKit:main Mar 2, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@dcrousso dcrousso Awaiting requested review from dcrousso dcrousso is a code owner

@patrickangle patrickangle Awaiting requested review from patrickangle patrickangle is a code owner

Assignees

@pgorszkowski-igalia pgorszkowski-igalia

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
5 participants
@pgorszkowski-igalia @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @magomez