[JSC] x64 CCall returnValueGPR is not in m_validGPRs #10924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 1d95e52) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=253227 rdar://106127760 Reviewed by Mark Lam. x64's returnValueGPR is not in m_validGPRs. So we cannot bind it to Location. We should move it to argumentGPR0 if returnValueGPR is not argumentGPR0, this is kind of a hack and we should change emitCCall in the future to make it more barebone like DFG's callOperation. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::emitCCall): Canonical link: https://commits.webkit.org/261048@main
webkit-early-warning-system
force-pushed
the
eng/JSC-x64-CCall-returnValueGPR-is-not-in-m_validGPRs
branch
from
1d95e52
to
adae6f1
Compare
|
Committed 261048@main (adae6f1): https://commits.webkit.org/261048@main Reviewed commits have been landed. Closing PR #10924 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adae6f1
1d95e52
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 jsc-mips-tests