[JSC] Fix floating point negation in WasmBBQJIT #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash b99eb86) |
🛠 jsc-armv7
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=253262 rdar://106161437 Reviewed by Justin Michaud. This patch aligns WasmBBQJIT to exactly how f32 / f64 negation is implemented in Air. This is required since wasm cares NaN's bit patterns. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addF32Neg): (JSC::Wasm::BBQJIT::addF64Neg): Canonical link: https://commits.webkit.org/261102@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Fix-floating-point-negation-in-WasmBBQJIT
branch
from
b99eb86
to
f357cb4
Compare
|
Committed 261102@main (f357cb4): https://commits.webkit.org/261102@main Reviewed commits have been landed. Closing PR #10956 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Fix-floating-point-negation-in-WasmBBQJIT
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f357cb4
b99eb86
🛠 mac🛠 wpe🛠 wincairo🛠 mac-AS-debug🛠 gtk🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim