Parse list-style-type custom-ident if counter-style is enabled #10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash b24be12)
|
vitorroriz
force-pushed
the
eng/Parse-list-style-type-custom-ident-if-counter-style-is-enabled
branch
from
b24be12
to
1ae8b6d
Compare
|
EWS run on current version of this PR (hash 1ae8b6d)
|
nt1m
approved these changes
Mar 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=253291 rdar://problem/106175917 Reviewed by Tim Nguyen. list-style-type should accept custom-ident values only if counter-styles-at-rule is enabled. * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::operator==): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeListStyleType): * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueListStyleType): Canonical link: https://commits.webkit.org/261154@main
webkit-commit-queue
force-pushed
the
eng/Parse-list-style-type-custom-ident-if-counter-style-is-enabled
branch
from
1ae8b6d
to
eb7c428
Compare
|
Committed 261154@main (eb7c428): https://commits.webkit.org/261154@main Reviewed commits have been landed. Closing PR #10982 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb7c428
1ae8b6d
🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-ios🛠 tv🧪 mac-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch-sim