Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CookieAcceptPolicy related code from WebProcessPool #11015

Conversation

szewai
Copy link
Contributor

@szewai szewai commented Mar 3, 2023

17ba29f

Remove CookieAcceptPolicy related code from WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=253333
rdar://106203382

Reviewed by Alex Christensen.

CookieAcceptPolicy management has been moved to API::HTTPCookieStore.

* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setCookieAcceptPolicy:]): Deleted.
(-[WKProcessPool _syncNetworkProcessCookies]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/261176@main

d3af9f8

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch   πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge   πŸ›  watch-sim

@szewai szewai requested a review from cdumez as a code owner March 3, 2023 19:17
@szewai szewai self-assigned this Mar 3, 2023
@szewai szewai added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 3, 2023
@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Mar 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=253333
rdar://106203382

Reviewed by Alex Christensen.

CookieAcceptPolicy management has been moved to API::HTTPCookieStore.

* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setCookieAcceptPolicy:]): Deleted.
(-[WKProcessPool _syncNetworkProcessCookies]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/261176@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-CookieAcceptPolicy-related-code-from-WebProcessPool branch from d3af9f8 to 17ba29f Compare March 3, 2023 23:17
@webkit-early-warning-system webkit-early-warning-system merged commit 17ba29f into WebKit:main Mar 3, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261176@main (17ba29f): https://commits.webkit.org/261176@main

Reviewed commits have been landed. Closing PR #11015 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 3, 2023
@szewai szewai deleted the eng/Remove-CookieAcceptPolicy-related-code-from-WebProcessPool branch March 13, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
4 participants