Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable @counter-style by default at preferences #11017

Conversation

@vitorroriz vitorroriz self-assigned this Mar 3, 2023
@vitorroriz vitorroriz added the CSS Cascading Style Sheets implementation label Mar 3, 2023
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vitorroriz vitorroriz added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Mar 3, 2023
@brentfulgham
Copy link
Contributor

The counter-style feature does not touch code that affects video frame count. This is a bad conclusion from the bot.

I have asked Vitor to override the block and land the change immediately.

https://bugs.webkit.org/show_bug.cgi?id=253326
rdar://106201695

Reviewed by Brent Fulgham.

Enabling cssCounterStylesAtRulesEnabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/261182@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Enable-counter-style-by-default-at-preferences branch from 58968fe to f553ff9 Compare March 4, 2023 00:41
@webkit-early-warning-system webkit-early-warning-system merged commit f553ff9 into WebKit:main Mar 4, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261182@main (f553ff9): https://commits.webkit.org/261182@main

Reviewed commits have been landed. Closing PR #11017 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
4 participants