Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue boxes appear at ends of selection for live text for images with vertical writing mode #11018

Merged
merged 1 commit into from Mar 4, 2023

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Mar 3, 2023

aa1b9db

Blue boxes appear at ends of selection for live text for images with vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=253335
rdar://106106328

Reviewed by Wenson Hsieh.

`SelectionRenderingBehavior::UseIndividualQuads` doesn't currently work well for images
with a vertical writing mode, so this PR works around it by only using that behavior for
horizontal writing modes.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::adjustLineHeightOfSelectionGeometries):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
(WebCore::RenderObject::collectSelectionGeometries):

Canonical link: https://commits.webkit.org/261209@main

c40baa2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac   πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ❌ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch   πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@rr-codes rr-codes self-assigned this Mar 3, 2023
@rr-codes rr-codes added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 3, 2023
@rr-codes rr-codes requested a review from whsieh March 3, 2023 19:45
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2023
…vertical writing mode

https://bugs.webkit.org/show_bug.cgi?id=253335
rdar://106106328

Reviewed by Wenson Hsieh.

`SelectionRenderingBehavior::UseIndividualQuads` doesn't currently work well for images
with a vertical writing mode, so this PR works around it by only using that behavior for
horizontal writing modes.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::adjustLineHeightOfSelectionGeometries):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
(WebCore::RenderObject::collectSelectionGeometries):

Canonical link: https://commits.webkit.org/261209@main
@webkit-commit-queue
Copy link
Collaborator

Committed 261209@main (aa1b9db): https://commits.webkit.org/261209@main

Reviewed commits have been landed. Closing PR #11018 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit aa1b9db into WebKit:main Mar 4, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants