-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid virtual function call to ScriptExecutionContext::settingsValues() in the bindings whenever possible #11088
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
cdumez:253418_settingsValues_bindings
Mar 6, 2023
Merged
Avoid virtual function call to ScriptExecutionContext::settingsValues() in the bindings whenever possible #11088
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
cdumez:253418_settingsValues_bindings
Mar 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash c547561) |
cdumez
force-pushed
the
253418_settingsValues_bindings
branch
from
March 6, 2023 01:12
c547561
to
6963b39
Compare
EWS run on previous version of this PR (hash 6963b39) |
cdumez
force-pushed
the
253418_settingsValues_bindings
branch
from
March 6, 2023 03:44
6963b39
to
e8a9b94
Compare
EWS run on current version of this PR (hash e8a9b94) |
darinadler
approved these changes
Mar 6, 2023
β¦() in the bindings whenever possible https://bugs.webkit.org/show_bug.cgi?id=253418 Reviewed by Darin Adler. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateRuntimeEnableConditionalString): * Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp: (WebCore::JSTestConditionalIncludesDOMConstructor::initializeProperties): (WebCore::JSTestConditionalIncludesPrototype::finishCreation): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp: (WebCore::JSTestDefaultToJSONPrototype::finishCreation): (WebCore::jsTestDefaultToJSONPrototypeFunction_toJSONBody): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp: (WebCore::jsTestDefaultToJSONInheritPrototypeFunction_toJSONBody): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp: (WebCore::jsTestDefaultToJSONInheritFinalPrototypeFunction_toJSONBody): * Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.cpp: (WebCore::convertDictionary<TestDerivedDictionary>): (WebCore::convertDictionaryToJS): * Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp: (WebCore::convertDictionary<TestDerivedDictionary2::Dictionary>): (WebCore::convertDictionaryToJS): * Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: (WebCore::JSTestEnabledBySettingDOMConstructor::initializeProperties): (WebCore::JSTestEnabledBySettingPrototype::finishCreation): (WebCore::JSTestEnabledBySetting::finishCreation): * Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp: (WebCore::JSTestEnabledForContext::finishCreation): * Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.cpp: (WebCore::convertDictionary<TestInheritedDictionary>): (WebCore::convertDictionaryToJS): * Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfacePrototype::finishCreation): * Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp: (WebCore::convertDictionary<DictionaryImplName>): (WebCore::convertDictionaryToJS): Canonical link: https://commits.webkit.org/261278@main
Committed 261278@main (0f0dde2): https://commits.webkit.org/261278@main Reviewed commits have been landed. Closing PR #11088 and removing active labels. |
webkit-early-warning-system
force-pushed
the
253418_settingsValues_bindings
branch
from
March 6, 2023 18:34
e8a9b94
to
0f0dde2
Compare
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0f0dde2
e8a9b94
π§ͺ mac-wk2-stress