[WebGPU] createRender/ComputePipelineAsync are unimplemented #11118

mwyrzykowski · 2023-03-06T18:03:57Z

`b794bac`

[WebGPU] createRender/ComputePipelineAsync are unimplemented
https://bugs.webkit.org/show_bug.cgi?id=253404
<radar://106244188>

Reviewed by Myles C. Maxfield.

Add GPUPipelineError and use it to implement createRenderPipelineAsync
and createComputePipelineAsync.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
Add files.

* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::createComputePipelineAsync):
(WebCore::GPUDevice::createRenderPipelineAsync):
Reject the promise on failure as specified in the specification.

* Source/WebCore/Modules/WebGPU/GPUPipelineError.cpp: Added.
(WebCore::GPUPipelineError::GPUPipelineError):
* Source/WebCore/Modules/WebGPU/GPUPipelineError.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineError.idl: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.idl: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.idl: Added.
New files.

* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:
Unified build fix.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::DeviceImpl::createComputePipelineAsync):
(PAL::WebGPU::DeviceImpl::createRenderPipelineAsync):
Return nullptr on failure.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUDevice.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
New files.

* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
New IDLInterface type.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipelineAsync):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipelineAsync):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::createComputePipelineAsync):
(WebKit::RemoteDevice::createRenderPipelineAsync):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
Return false or nullptr on failure from the callback.

* Source/WebCore/Modules/streams/WritableStream.cpp:
(WebCore::WritableStream::lock):
(WebCore::WritableStream::locked const):
(WebCore::WritableStream::internalWritableStream):
* Source/WebCore/Modules/streams/WritableStream.h:
(WebCore::WritableStream::lock): Deleted.
(WebCore::WritableStream::locked const): Deleted.
(WebCore::WritableStream::internalWritableStream): Deleted.
Unified build fixes.

Canonical link: https://commits.webkit.org/261415@main

ba9f13b

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-06T18:06:41Z

EWS run on previous version of this PR (hash d861fb9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

mwyrzykowski · 2023-03-06T18:19:36Z

Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp

@@ -29,9 +29,11 @@

 ALLOW_UNUSED_PARAMETERS_BEGIN
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+ALLOW_COMMA_BEGIN


unified build fixes

Really? Usually unified build fixes are just #includes....

In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/memory/memory.h:33: /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/base/macros.h:134:37: note: expanded from macro 'ABSL_HARDENING_ASSERT' #define ABSL_HARDENING_ASSERT(expr) ABSL_ASSERT(expr) /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/base/macros.h:98:3: note: expanded from macro 'ABSL_ASSERT' (ABSL_PREDICT_TRUE((expr)) ? static_cast<void>(0) \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource56.cpp:1: In file included from /Volumes/Data/OpenSource/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:33: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/frame_transformer_interface.h:18: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/video/encoded_frame.h:18: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/units/timestamp.h:21: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/units/time_delta.h:22: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/rtc_base/units/unit_base.h:20: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/rtc_base/checks.h:58: /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/strings/string_view.h:320:43: error: possible misuse of comma operator here [-Werror,-Wcomma] return ABSL_HARDENING_ASSERT(!empty()), ptr_[size() - 1]; /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/strings/string_view.h:320:12: note: cast expression to void to silence warning return ABSL_HARDENING_ASSERT(!empty()), ptr_[size() - 1]; In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource56.cpp:1: In file included from /Volumes/Data/OpenSource/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:33: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/frame_transformer_interface.h:18: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/webrtc/api/video/encoded_frame.h:17: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/types/optional.h:67: In file included from /Volumes/Data/OpenSource/WebKitBuild/Debug/usr/local/include/absl/types/internal/optional.h:24:

It depends on who includes Debug/usr/local/include/absl/strings/string_view.h first with the warning ignored

webkit-early-warning-system · 2023-03-06T21:46:38Z

EWS run on previous version of this PR (hash 37f1adc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-06T22:29:56Z

EWS run on previous version of this PR (hash f895641)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	❌ 🛠 gtk
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	~~🛠 watch~~	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-03-06T22:51:25Z

EWS run on previous version of this PR (hash 2bf8c24)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-07T01:04:00Z

EWS run on previous version of this PR (hash cbb4078)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	❌ 🧪 api-gtk
	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-03-07T01:19:50Z

EWS run on previous version of this PR (hash bd0c564)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	❌ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-03-07T01:45:04Z

EWS run on previous version of this PR (hash e4656bf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

litherum

Thanks for keeping the patch fairly mechanical 👍

litherum · 2023-03-07T06:13:43Z

Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp

@@ -29,9 +29,11 @@

 ALLOW_UNUSED_PARAMETERS_BEGIN
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+ALLOW_COMMA_BEGIN


Really? Usually unified build fixes are just #includes....

litherum · 2023-03-07T06:15:37Z

Source/WebGPU/WebGPU/ComputePipeline.mm

-    UNUSED_PARAM(descriptor);
-    instance().scheduleWork([strongThis = Ref { *this }, callback = WTFMove(callback)]() mutable {
-        callback(WGPUCreatePipelineAsyncStatus_InternalError, ComputePipeline::createInvalid(strongThis), { });
+    auto pipeline = createComputePipeline(descriptor);


I think this is fine for now, but we should at least file a bug and add a FIXME with a link to the bug about doing this actually asynchronously

litherum · 2023-03-07T06:15:45Z

Source/WebGPU/WebGPU/RenderPipeline.mm

-    UNUSED_PARAM(descriptor);
-    instance().scheduleWork([strongThis = Ref { *this }, callback = WTFMove(callback)]() mutable {
-        callback(WGPUCreatePipelineAsyncStatus_InternalError, RenderPipeline::createInvalid(strongThis), { });
+    auto pipeline = createRenderPipeline(descriptor);


litherum · 2023-03-07T06:16:50Z

Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp

-        objectHeap->addObject(identifier, remoteComputePipeline);
-        callback();
+    m_backing->createComputePipelineAsync(*convertedDescriptor, [callback = WTFMove(callback), objectHeap = Ref { m_objectHeap }, streamConnection = m_streamConnection.copyRef(), identifier] (RefPtr<PAL::WebGPU::ComputePipeline>&& computePipeline) mutable {
+        bool result = computePipeline.get();


This is so we know whether or not to reject the promise, I assume?

that's correct

webkit-early-warning-system · 2023-03-08T02:02:49Z

EWS run on previous version of this PR (hash cdf1a4c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-08T16:50:46Z

EWS run on current version of this PR (hash ba9f13b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

mwyrzykowski · 2023-03-08T18:49:09Z

Source/WebCore/Modules/streams/WritableStream.cpp

@@ -45,6 +46,23 @@ ExceptionOr<Ref<WritableStream>> WritableStream::create(JSC::JSGlobalObject& glo
    return create(globalObject, underlyingSinkValue, strategyValue);
 }

+WritableStream::~WritableStream() = default;


cc @youennf to verify these unified build fixes are acceptable. They are appearing in #11154 too, I think these changes will fix them there as well

This seems fine, JSDOMGlobalObject.h is now included in WritableStream.h so no need to include it in WritableStream.cpp

https://bugs.webkit.org/show_bug.cgi?id=253404 <radar://106244188> Reviewed by Myles C. Maxfield. Add GPUPipelineError and use it to implement createRenderPipelineAsync and createComputePipelineAsync. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: Add files. * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: (WebCore::GPUDevice::createComputePipelineAsync): (WebCore::GPUDevice::createRenderPipelineAsync): Reject the promise on failure as specified in the specification. * Source/WebCore/Modules/WebGPU/GPUPipelineError.cpp: Added. (WebCore::GPUPipelineError::GPUPipelineError): * Source/WebCore/Modules/WebGPU/GPUPipelineError.h: Added. * Source/WebCore/Modules/WebGPU/GPUPipelineError.idl: Added. * Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.h: Added. * Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.idl: Added. * Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.h: Added. * Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.idl: Added. New files. * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp: Unified build fix. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::DeviceImpl::createComputePipelineAsync): (PAL::WebGPU::DeviceImpl::createRenderPipelineAsync): Return nullptr on failure. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h: * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUDevice.h: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: New files. * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: New IDLInterface type. * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::Device::createComputePipelineAsync): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipelineAsync): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp: (WebKit::RemoteDevice::createComputePipelineAsync): (WebKit::RemoteDevice::createRenderPipelineAsync): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync): (WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: Return false or nullptr on failure from the callback. * Source/WebCore/Modules/streams/WritableStream.cpp: (WebCore::WritableStream::lock): (WebCore::WritableStream::locked const): (WebCore::WritableStream::internalWritableStream): * Source/WebCore/Modules/streams/WritableStream.h: (WebCore::WritableStream::lock): Deleted. (WebCore::WritableStream::locked const): Deleted. (WebCore::WritableStream::internalWritableStream): Deleted. Unified build fixes. Canonical link: https://commits.webkit.org/261415@main

webkit-commit-queue · 2023-03-09T09:00:45Z

Committed 261415@main (b794bac): https://commits.webkit.org/261415@main

Reviewed commits have been landed. Closing PR #11118 and removing active labels.

mwyrzykowski requested a review from cdumez as a code owner March 6, 2023 18:03

mwyrzykowski self-assigned this Mar 6, 2023

mwyrzykowski added the WebGPU For bugs in WebGPU label Mar 6, 2023

mwyrzykowski requested review from tadeuzagallo, litherum and djg March 6, 2023 18:19

mwyrzykowski commented Mar 6, 2023

View reviewed changes

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from d861fb9 to 37f1adc Compare March 6, 2023 21:46

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from 37f1adc to f895641 Compare March 6, 2023 22:29

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from f895641 to 2bf8c24 Compare March 6, 2023 22:51

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from 2bf8c24 to cbb4078 Compare March 7, 2023 01:01

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from cbb4078 to bd0c564 Compare March 7, 2023 01:18

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from bd0c564 to e4656bf Compare March 7, 2023 01:42

litherum approved these changes Mar 7, 2023

View reviewed changes

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from e4656bf to cdf1a4c Compare March 8, 2023 02:01

mwyrzykowski force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from cdf1a4c to ba9f13b Compare March 8, 2023 16:50

mwyrzykowski requested a review from youennf March 8, 2023 16:53

mwyrzykowski commented Mar 8, 2023

View reviewed changes

mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2023

webkit-commit-queue force-pushed the eng/WebGPU-createRenderComputePipelineAsync-are-unimplemented branch from ba9f13b to b794bac Compare March 9, 2023 09:00

webkit-commit-queue merged commit b794bac into WebKit:main Mar 9, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WebGPU] createRender/ComputePipelineAsync are unimplemented #11118

[WebGPU] createRender/ComputePipelineAsync are unimplemented #11118

mwyrzykowski commented Mar 6, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 6, 2023 •

edited

mwyrzykowski Mar 6, 2023

litherum Mar 7, 2023

mwyrzykowski Mar 7, 2023

mwyrzykowski Mar 7, 2023

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

litherum left a comment

litherum Mar 7, 2023

litherum Mar 7, 2023

litherum Mar 7, 2023

litherum Mar 7, 2023

mwyrzykowski Mar 7, 2023

webkit-early-warning-system commented Mar 8, 2023 •

edited

webkit-early-warning-system commented Mar 8, 2023 •

edited

mwyrzykowski Mar 8, 2023

youennf Mar 9, 2023

webkit-commit-queue commented Mar 9, 2023

[WebGPU] createRender/ComputePipelineAsync are unimplemented #11118

[WebGPU] createRender/ComputePipelineAsync are unimplemented #11118

Conversation

mwyrzykowski commented Mar 6, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Mar 6, 2023 • edited

webkit-early-warning-system commented Mar 6, 2023 • edited

webkit-early-warning-system commented Mar 6, 2023 • edited

webkit-early-warning-system commented Mar 7, 2023 • edited

webkit-early-warning-system commented Mar 7, 2023 • edited

webkit-early-warning-system commented Mar 7, 2023 • edited

litherum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Mar 8, 2023 • edited

webkit-early-warning-system commented Mar 8, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-commit-queue commented Mar 9, 2023

mwyrzykowski commented Mar 6, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 6, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

webkit-early-warning-system commented Mar 7, 2023 •

edited

webkit-early-warning-system commented Mar 8, 2023 •

edited

webkit-early-warning-system commented Mar 8, 2023 •

edited