Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the list of ARIA roles used for Interaction Regions #11132

Merged

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented Mar 6, 2023

e4492ac

Complete the list of ARIA roles used for Interaction Regions
https://bugs.webkit.org/show_bug.cgi?id=253460
<rdar://105700895>

Reviewed by Tim Horton.

Expand the list of ARIA roles that enable the creation of an
Interaction Region.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):
Extract the ARIA check in a function.
(WebCore::shouldAllowNonPointerCursorForElement):
Use the new function when evaluating an element missing
`cursor:pointer`.

* LayoutTests/interaction-region/aria-roles-expected.txt:
* LayoutTests/interaction-region/aria-roles.html:
Fix an issue with the existing `role="button"` test case.
Add new cases covering this change.

Canonical link: https://commits.webkit.org/261337@main

2949ee5

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch   πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@etiennesegonzac etiennesegonzac self-assigned this Mar 6, 2023
@etiennesegonzac etiennesegonzac added the Layout and Rendering For bugs with layout and rendering of Web pages. label Mar 6, 2023
@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=253460
<rdar://105700895>

Reviewed by Tim Horton.

Expand the list of ARIA roles that enable the creation of an
Interaction Region.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):
Extract the ARIA check in a function.
(WebCore::shouldAllowNonPointerCursorForElement):
Use the new function when evaluating an element missing
`cursor:pointer`.

* LayoutTests/interaction-region/aria-roles-expected.txt:
* LayoutTests/interaction-region/aria-roles.html:
Fix an issue with the existing `role="button"` test case.
Add new cases covering this change.

Canonical link: https://commits.webkit.org/261337@main
@webkit-commit-queue
Copy link
Collaborator

Committed 261337@main (e4492ac): https://commits.webkit.org/261337@main

Reviewed commits have been landed. Closing PR #11132 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit e4492ac into WebKit:main Mar 7, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
4 participants