-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix result height when folding select in WasmBBQJIT #11247
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
ddegazio:eng/Fix-result-height-when-folding-select-in-WasmBBQJIT
Mar 9, 2023
Merged
Fix result height when folding select in WasmBBQJIT #11247
webkit-commit-queue
merged 1 commit into
WebKit:main
from
ddegazio:eng/Fix-result-height-when-folding-select-in-WasmBBQJIT
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on current version of this PR (hash 7253ec2) |
msaboff
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
Constellation
approved these changes
Mar 8, 2023
https://bugs.webkit.org/show_bug.cgi?id=253592 rdar://106420016 Reviewed by Michael Saboff and Yusuke Suzuki. Currently, when BBQ JIT folds a select instruction, it naively selects between the Value operands it was given based on the constant condition. This can sometimes result in a resulting temp with an incorrect stack height. This patch changes select to consume all operands, not just the one we didn't select, similar to the non-folded case. It also sets the result to the right temp index, if applicable (we can still return a constant, where the height of the value is irrelevant), and allocates it independently. Finally, this patch also includes some semi-related changes to the BBQ JIT move helpers, allowing them to be used to move values between any two Locations, instead of the current implementation which requires the source operand to be a Value. * JSTests/wasm/stress/foldable-select.js: Added. (async test): * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addSelect): (JSC::Wasm::BBQJIT::emitStore): (JSC::Wasm::BBQJIT::emitMoveMemory): (JSC::Wasm::BBQJIT::emitMoveRegister): (JSC::Wasm::BBQJIT::emitLoad): (JSC::Wasm::BBQJIT::emitMove): Canonical link: https://commits.webkit.org/261461@main
webkit-commit-queue
force-pushed
the
eng/Fix-result-height-when-folding-select-in-WasmBBQJIT
branch
from
March 9, 2023 21:26
7253ec2
to
c0310d3
Compare
Committed 261461@main (c0310d3): https://commits.webkit.org/261461@main Reviewed commits have been landed. Closing PR #11247 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c0310d3
7253ec2
π§ͺ gtk-wk2π§ͺ api-gtk