Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folded i64 comparisons should return i32 in WasmBBQJIT #11257

Conversation

ddegazio
Copy link
Contributor

@ddegazio ddegazio commented Mar 8, 2023

fb8b78d

Folded i64 comparisons should return i32 in WasmBBQJIT
https://bugs.webkit.org/show_bug.cgi?id=253603
rdar://106419423

Reviewed by Yusuke Suzuki.

Makes i64 comparisons in WasmBBQJIT return i32 constants when folded,
instead of i64. Also adds tests exhaustively testing constant folding
for each type and comparison op.

* JSTests/wasm/stress/comparison-folding-f32.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-f64.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-i32.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-i64.js: Added.
(async test):
* JSTests/wasm/stress/switch-on-boolean.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitCompareI64):

Canonical link: https://commits.webkit.org/261438@main

edbbc0c

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ›  jsc-mips
βœ… πŸ§ͺ jsc-mips-tests

@ddegazio ddegazio requested a review from a team as a code owner March 8, 2023 22:32
@ddegazio ddegazio self-assigned this Mar 8, 2023
@ddegazio ddegazio added the WebAssembly For bugs in JavaScript WebAssembly label Mar 8, 2023
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@ddegazio ddegazio added the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=253603
rdar://106419423

Reviewed by Yusuke Suzuki.

Makes i64 comparisons in WasmBBQJIT return i32 constants when folded,
instead of i64. Also adds tests exhaustively testing constant folding
for each type and comparison op.

* JSTests/wasm/stress/comparison-folding-f32.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-f64.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-i32.js: Added.
(async test):
* JSTests/wasm/stress/comparison-folding-i64.js: Added.
(async test):
* JSTests/wasm/stress/switch-on-boolean.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitCompareI64):

Canonical link: https://commits.webkit.org/261438@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Folded-i64-comparisons-should-return-i32-in-WasmBBQJIT branch from edbbc0c to fb8b78d Compare March 9, 2023 16:42
@webkit-commit-queue
Copy link
Collaborator

Committed 261438@main (fb8b78d): https://commits.webkit.org/261438@main

Reviewed commits have been landed. Closing PR #11257 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fb8b78d into WebKit:main Mar 9, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebAssembly For bugs in JavaScript WebAssembly
Projects
None yet
4 participants