New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebAssembly] Fix tests and build on x86-64 Linux with BBQJIT #11268
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
takikawa:eng/WebAssembly-Fix-tests-and-build-on-x86-64-Linux-with-BBQJIT
Mar 9, 2023
Merged
[WebAssembly] Fix tests and build on x86-64 Linux with BBQJIT #11268
webkit-commit-queue
merged 1 commit into
WebKit:main
from
takikawa:eng/WebAssembly-Fix-tests-and-build-on-x86-64-Linux-with-BBQJIT
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash a0516ba) |
Constellation
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with comments.
takikawa
force-pushed
the
eng/WebAssembly-Fix-tests-and-build-on-x86-64-Linux-with-BBQJIT
branch
from
March 9, 2023 07:46
a0516ba
to
d54e299
Compare
EWS run on current version of this PR (hash d54e299) |
https://bugs.webkit.org/show_bug.cgi?id=253618 Reviewed by Yusuke Suzuki. This patch first enables building of the BBQJIT on x86-64 Linux platforms by adding a line in WebKitFeatures.cmake. The rest of the patch fixes build issues with GCC. - GCC doesn't support std::fabsf so use std::fabs instead. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79700) - GCC doesn't support explicit specialization in class scope so this patch uses a `if constexpr` workaround. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282) - Add RELEASE_ASSERT_NOT_REACHED to suppress warnings. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::Location::fromArgumentLocation): (JSC::Wasm::BBQJIT::loadOpForTypeKind): (JSC::Wasm::BBQJIT::storeOpForTypeKind): (JSC::Wasm::BBQJIT::addF32Copysign): (JSC::Wasm::BBQJIT::fromJSCReg): (JSC::Wasm::BBQJIT::fromJSCReg<RegisterID>): Deleted. (JSC::Wasm::BBQJIT::fromJSCReg<FPRegisterID>): Deleted. * Source/cmake/WebKitFeatures.cmake: Canonical link: https://commits.webkit.org/261417@main
webkit-commit-queue
force-pushed
the
eng/WebAssembly-Fix-tests-and-build-on-x86-64-Linux-with-BBQJIT
branch
from
March 9, 2023 09:33
d54e299
to
361c5fb
Compare
Committed 261417@main (361c5fb): https://commits.webkit.org/261417@main Reviewed commits have been landed. Closing PR #11268 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
361c5fb
d54e299
π wincairoπ§ͺ wpe-wk2π§ͺ ios-wk2π gtkπ§ͺ api-iosπ§ͺ mac-wk1π§ͺ api-gtkπ§ͺ mac-AS-debug-wk2