Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreviewed build fixes for RISCV64 #11358

Conversation

zdobersek
Copy link
Contributor

@zdobersek zdobersek commented Mar 10, 2023

c07cdb6

Unreviewed build fixes for RISCV64
https://bugs.webkit.org/show_bug.cgi?id=253700

Unreviewed build fixes for RISCV64 builds of JavaScriptCore.

* Source/JavaScriptCore/assembler/MacroAssembler.h: Enable the moveFloat and
moveDouble methods that work with immediate values, sharing the scratch register
variant with x86-64.
* Source/JavaScriptCore/offlineasm/riscv64.rb: Also generate WASM placeholders
for the loadv and storev opcodes, used in WebAssembly.asm.
* Source/WTF/wtf/PlatformEnable.h: Avoid further compilation issues by enabling
ENABLE_WEBASSEMBLY_B3JIT alongside ENABLE_WEBASSEMBLY.

Canonical link: https://commits.webkit.org/261498@main

7c6cc12

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ›  jsc-mips
βœ… πŸ§ͺ jsc-mips-tests

@zdobersek zdobersek requested a review from a team as a code owner March 10, 2023 12:48
@zdobersek zdobersek self-assigned this Mar 10, 2023
@zdobersek zdobersek added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 10, 2023
@zdobersek zdobersek force-pushed the eng/Unreviewed-build-fixes-for-RISCV64 branch from 5349b56 to 7c6cc12 Compare March 10, 2023 13:11
@zdobersek zdobersek added the merge-queue Applied to send a pull request to merge-queue label Mar 10, 2023
https://bugs.webkit.org/show_bug.cgi?id=253700

Unreviewed build fixes for RISCV64 builds of JavaScriptCore.

* Source/JavaScriptCore/assembler/MacroAssembler.h: Enable the moveFloat and
moveDouble methods that work with immediate values, sharing the scratch register
variant with x86-64.
* Source/JavaScriptCore/offlineasm/riscv64.rb: Also generate WASM placeholders
for the loadv and storev opcodes, used in WebAssembly.asm.
* Source/WTF/wtf/PlatformEnable.h: Avoid further compilation issues by enabling
ENABLE_WEBASSEMBLY_B3JIT alongside ENABLE_WEBASSEMBLY.

Canonical link: https://commits.webkit.org/261498@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewed-build-fixes-for-RISCV64 branch from 7c6cc12 to c07cdb6 Compare March 10, 2023 15:34
@webkit-commit-queue
Copy link
Collaborator

Committed 261498@main (c07cdb6): https://commits.webkit.org/261498@main

Reviewed commits have been landed. Closing PR #11358 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c07cdb6 into WebKit:main Mar 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
3 participants