Speedup WebExtensionMatchPattern::matchesAllHosts() to avoid makeString(). #11370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 066d494)
|
b-weinstein
approved these changes
Mar 10, 2023
xeenon
added
the
unsafe-merge-queue
…ng(). https://webkit.org/b/253722 rdar://106052464 Reviewed by Brian Weinstein. * Source/WebCore/page/UserContentURLPattern.cpp: (WebCore::UserContentURLPattern::originalHost const): Use matchAllHosts(). * Source/WebCore/page/UserContentURLPattern.h: (WebCore::UserContentURLPattern::matchAllHosts const): Added. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm: (WebKit::WebExtensionMatchPattern::matchesAllHosts const): Use matchAllHosts() instead of host(). Canonical link: https://commits.webkit.org/261510@main
webkit-commit-queue
force-pushed
the
bug/253722
branch
from
066d494
to
f112de9
Compare
|
Committed 261510@main (f112de9): https://commits.webkit.org/261510@main Reviewed commits have been landed. Closing PR #11370 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f112de9
066d494
🛠 ios🛠 mac🛠 wincairo🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 mac-wk2🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim