Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] GPUQueue.writeBuffer does not support default value for dataOffset #11397

Merged
merged 1 commit into from Mar 12, 2023
Merged

[WebGPU] GPUQueue.writeBuffer does not support default value for dataOffset #11397

merged 1 commit into from Mar 12, 2023

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Mar 11, 2023 •
edited by webkit-early-warning-system

cac6801

[WebGPU] GPUQueue.writeBuffer does not support default value for dataOffset
https://bugs.webkit.org/show_bug.cgi?id=253747
<radar://106582095>

Reviewed by Myles C. Maxfield.

Workaround https://bugs.webkit.org/show_bug.cgi?id=240219 by placing the default
value for an optional inside the cpp file.

onSubmittedWorkDone.html now passes, so enable it.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/onSubmittedWorkDone-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::GPUQueue::writeBuffer):
* Source/WebCore/Modules/WebGPU/GPUQueue.h:
* Source/WebCore/Modules/WebGPU/GPUQueue.idl:

Canonical link: https://commits.webkit.org/261551@main

4075731

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Mar 11, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Mar 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4075731)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

litherum
litherum approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@litherum litherum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeessssssssss

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Mar 12, 2023
@mwyrzykowski
[WebGPU] GPUQueue.writeBuffer does not support default value for data…
cac6801 
…Offset

https://bugs.webkit.org/show_bug.cgi?id=253747
<radar://106582095>

Reviewed by Myles C. Maxfield.

Workaround https://bugs.webkit.org/show_bug.cgi?id=240219 by placing the default
value for an optional inside the cpp file.

onSubmittedWorkDone.html now passes, so enable it.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/onSubmittedWorkDone-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::GPUQueue::writeBuffer):
* Source/WebCore/Modules/WebGPU/GPUQueue.h:
* Source/WebCore/Modules/WebGPU/GPUQueue.idl:

Canonical link: https://commits.webkit.org/261551@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-GPUQueue-writeBuffer-does-not-support-default-value-for-dataOffset branch from 4075731 to cac6801 Compare March 12, 2023 16:53
@webkit-commit-queue
Copy link
Collaborator

Committed 261551@main (cac6801): https://commits.webkit.org/261551@main

Reviewed commits have been landed. Closing PR #11397 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cac6801 into WebKit:main Mar 12, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

@djg djg Awaiting requested review from djg

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
4 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @litherum