WebScriptObject: Refactor getListFromNSArray to use a for-in loop #11439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 9c41fdd)
|
AtariDreams
force-pushed
the
eng/getListFromNSArray-should-use-a-for-in-loop
branch
from
9c41fdd
to
503914d
Compare
AtariDreams
changed the title
|
EWS run on previous version of this PR (hash 503914d)
|
Ahmad-S792
added
the
WebCore Misc.
AtariDreams
force-pushed
the
eng/getListFromNSArray-should-use-a-for-in-loop
branch
from
503914d
to
9f92b20
Compare
|
EWS run on previous version of this PR (hash 9f92b20)
|
AtariDreams
force-pushed
the
eng/getListFromNSArray-should-use-a-for-in-loop
branch
from
9f92b20
to
c796cab
Compare
|
EWS run on previous version of this PR (hash c796cab)
|
aproskuryakov
requested changes
Mar 13, 2023
There was a problem hiding this comment.
Good change. Please remove the braces around what's now a single line block: https://webkit.org/code-style-guidelines/#braces
Done! |
AtariDreams
force-pushed
the
eng/getListFromNSArray-should-use-a-for-in-loop
branch
2 times, most recently
from
6b53d04
to
1b52e9e
Compare
aproskuryakov
approved these changes
Mar 14, 2023
aproskuryakov
added
the
merge-queue
|
EWS run on current version of this PR (hash 1b52e9e)
|
|
EWS run on previous version of this PR (hash 6b53d04) |
https://bugs.webkit.org/show_bug.cgi?id=253823 Reviewed by Alexey Proskuryakov. This makes the code cleaner and more terse. * Source\WebCore\bridge\objc\WebScriptObject.mm:(getListFromNSArray): Prefer for-in loop over regular for loop for iteration of an NSArray. Canonical link: https://commits.webkit.org/261607@main
webkit-commit-queue
force-pushed
the
eng/getListFromNSArray-should-use-a-for-in-loop
branch
from
1b52e9e
to
5b1535c
Compare
|
Committed 261607@main (5b1535c): https://commits.webkit.org/261607@main Reviewed commits have been landed. Closing PR #11439 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5b1535c
1b52e9e
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🛠 gtk🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch