Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][WebRTC] StatsCollector: Update GStreamer version checks #11546

Merged
merged 1 commit into from Mar 15, 2023
Merged

[GStreamer][WebRTC] StatsCollector: Update GStreamer version checks #11546

merged 1 commit into from Mar 15, 2023

Conversation

philn
Copy link
Member

@philn philn commented Mar 15, 2023 •
edited by webkit-early-warning-system

2e8371e

[GStreamer][WebRTC] StatsCollector: Update GStreamer version checks
https://bugs.webkit.org/show_bug.cgi?id=253955

Reviewed by Xabier Rodriguez-Calvar.

GStreamer 1.22 is out so no need to check 1.21 anymore.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::fillReportCallback):

Canonical link: https://commits.webkit.org/261681@main

cf38c4a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@philn philn self-assigned this Mar 15, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 15, 2023
@philn philn requested a review from calvaris March 15, 2023 10:42
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash cf38c4a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2023
@philn
[GStreamer][WebRTC] StatsCollector: Update GStreamer version checks
2e8371e 
https://bugs.webkit.org/show_bug.cgi?id=253955

Reviewed by Xabier Rodriguez-Calvar.

GStreamer 1.22 is out so no need to check 1.21 anymore.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::fillReportCallback):

Canonical link: https://commits.webkit.org/261681@main
@webkit-commit-queue
Copy link
Collaborator

Committed 261681@main (2e8371e): https://commits.webkit.org/261681@main

Reviewed commits have been landed. Closing PR #11546 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2e8371e into WebKit:main Mar 15, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2023
@philn philn deleted the eng/253955 branch March 15, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@philn @webkit-early-warning-system @webkit-commit-queue @calvaris