[git-webkit] Force pre-push hooks to be up-to-date #11563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 2340f6a) |
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/git-webkit-Force-pre-push-hooks-to-be-up-to-date
branch
from
2340f6a
to
a9f47f1
Compare
|
EWS run on previous version of this PR (hash a9f47f1) |
webkit-ews-buildbot
added
the
merging-blocked
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/git-webkit-Force-pre-push-hooks-to-be-up-to-date
branch
from
a9f47f1
to
4f6f658
Compare
|
EWS run on current version of this PR (hash 4f6f658) |
JonWBedard
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=253972 rdar://106760739 Reviewed by Aakash Jain and Ryan Haddad. If a checkout defines a pre-push hook, prevent users from running commands which invoke `git push` without first installing the hook. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: (InstallHooks.version_for): Extract version from a hook template file. (InstallHooks.hook_needs_update): Compare the checked in hook template to the installed hook template. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py: (Land.main): Exit program if our pre-push hook is out of date. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py: (Publish.main): Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.main): Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: Added. (TestInstallHooks): Canonical link: https://commits.webkit.org/261970@main
webkit-commit-queue
force-pushed
the
eng/git-webkit-Force-pre-push-hooks-to-be-up-to-date
branch
from
4f6f658
to
57dd97a
Compare
|
Committed 261970@main (57dd97a): https://commits.webkit.org/261970@main Reviewed commits have been landed. Closing PR #11563 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/git-webkit-Force-pre-push-hooks-to-be-up-to-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
57dd97a
4f6f658
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 watch