Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS][GPUP] Add syscall to sandbox #11616

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[macOS][GPUP] Add syscall to sandbox #11616

merged 1 commit into from
Mar 16, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Mar 16, 2023 •
edited by webkit-early-warning-system

c886a4a

[macOS][GPUP] Add syscall to sandbox
https://bugs.webkit.org/show_bug.cgi?id=254036
rdar://problem/106815986

Reviewed by Brent Fulgham.

Add syscall related to process termination to the GPU process sandbox on macOS.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/261762@main

f61d7fd

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Mar 16, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 16, 2023
@pvollan pvollan force-pushed the eng/macOSGPUP-Add-syscall-to-sandbox branch from b055c61 to f61d7fd Compare March 16, 2023 18:06
brentfulgham
brentfulgham approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pvollan
Copy link
Contributor Author

pvollan commented Mar 16, 2023

LGTM.

Thanks for reviewing!

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Mar 16, 2023
@pvollan
[macOS][GPUP] Add syscall to sandbox
c886a4a 
https://bugs.webkit.org/show_bug.cgi?id=254036
rdar://problem/106815986

Reviewed by Brent Fulgham.

Add syscall related to process termination to the GPU process sandbox on macOS.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/261762@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/macOSGPUP-Add-syscall-to-sandbox branch from f61d7fd to c886a4a Compare March 16, 2023 19:48
@webkit-commit-queue
Copy link
Collaborator

Committed 261762@main (c886a4a): https://commits.webkit.org/261762@main

Reviewed commits have been landed. Closing PR #11616 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c886a4a into WebKit:main Mar 16, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f61d7fd)

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b055c61)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
⏳ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 webkitpy   🧪 api-ios   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
⏳ 🧪 services ⏳ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@MenloDorian MenloDorian Awaiting requested review from MenloDorian

@gavin-apple gavin-apple Awaiting requested review from gavin-apple

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-commit-queue @webkit-early-warning-system @brentfulgham