Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaStream][GStreamer] Add support for InputDeviceInfo #11618

Merged
merged 1 commit into from Mar 24, 2023
Merged

[MediaStream][GStreamer] Add support for InputDeviceInfo #11618

merged 1 commit into from Mar 24, 2023

Conversation

philn
Copy link
Member

@philn philn commented Mar 16, 2023 •
edited by webkit-early-warning-system

dcc9895

[MediaStream][GStreamer] Add support for InputDeviceInfo
https://bugs.webkit.org/show_bug.cgi?id=254040

Reviewed by Carlos Garcia Campos.

The GLib UIProcess->WebProcess IPC now takes in account the desire for the UIProcess to reveal
device IDs and labels.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/UIProcess/glib/UserMediaPermissionRequestManagerProxyGLib.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::getMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h:
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.messages.in:

Canonical link: https://commits.webkit.org/262065@main

6ee739c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@philn philn requested a review from a team as a code owner March 16, 2023 18:39
@philn philn self-assigned this Mar 16, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 16, 2023
@philn philn requested a review from youennf March 16, 2023 18:40
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 16, 2023
@philn philn removed the merging-blocked Applied to prevent a change from being merged label Mar 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 6ee739c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 8eb5cc7)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
⏳ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
⏳ 🧪 webkitpy   🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
⏳ 🧪 services ⏳ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 16, 2023
@philn philn removed the merging-blocked Applied to prevent a change from being merged label Mar 17, 2023
@philn philn requested a review from zdobersek March 20, 2023 10:27
@philn
Copy link
Member Author

philn commented Mar 21, 2023

Ping

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2023
@philn
[MediaStream][GStreamer] Add support for InputDeviceInfo
dcc9895 
https://bugs.webkit.org/show_bug.cgi?id=254040

Reviewed by Carlos Garcia Campos.

The GLib UIProcess->WebProcess IPC now takes in account the desire for the UIProcess to reveal
device IDs and labels.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/UIProcess/glib/UserMediaPermissionRequestManagerProxyGLib.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::platformGetMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::getMediaStreamDevices):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h:
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.messages.in:

Canonical link: https://commits.webkit.org/262065@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262065@main (dcc9895): https://commits.webkit.org/262065@main

Reviewed commits have been landed. Closing PR #11618 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2023
@webkit-commit-queue webkit-commit-queue merged commit dcc9895 into WebKit:main Mar 24, 2023
@philn philn deleted the eng/254040 branch March 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@youennf youennf Awaiting requested review from youennf

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
5 participants
@philn @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @webkit-ews-buildbot