[git-webkit] Handle ssh protocol with user #11629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash df85b4a) |
webkit-ews-buildbot
added
the
merging-blocked
aj062
approved these changes
Mar 17, 2023
JonWBedard
removed
the
merging-blocked
JonWBedard
force-pushed
the
eng/git-webkit-Handle-ssh-protocol-with-user
branch
from
df85b4a
to
5abb8db
Compare
JonWBedard
added
skip-ews
|
EWS run on current version of this PR (hash 5abb8db)
|
https://bugs.webkit.org/show_bug.cgi?id=254052 rdar://106832995 Reviewed by Aakash Jain. A remote URL of the format 'ssh://git@...' is valid, but breaks our regex. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/hooks/pre-push: Use a regex defined by our template. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: (InstallHooks): Update REMOTE_RE to handle ssh protocol with user. (InstallHooks.main): Pass REMOTE_RE to template. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: Added. (TestInstallHooks): (TestInstallHooks.setUp): (TestInstallHooks.test_regex): Canonical link: https://commits.webkit.org/261795@main
webkit-commit-queue
force-pushed
the
eng/git-webkit-Handle-ssh-protocol-with-user
branch
from
5abb8db
to
bb518ed
Compare
|
Committed 261795@main (bb518ed): https://commits.webkit.org/261795@main Reviewed commits have been landed. Closing PR #11629 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bb518ed
5abb8db
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🛠 gtk🧪 webkitpy🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 mac-wk2🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🧪 services🛠 watch🧪 mac-wk2-stress🛠 watch-sim