Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Refactor some logic around VideoFullscreenInterfaceAVKit #1168

Merged
merged 0 commits into from May 31, 2022

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented May 31, 2022

5771692

[iOS] Refactor some logic around `VideoFullscreenInterfaceAVKit`
https://bugs.webkit.org/show_bug.cgi?id=241113

Reviewed by Eric Carlson.

Adjust the window level of `VideoFullscreenInterfaceAVKit`'s window. No change in behavior.

* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):

Also refactor `WebPageProxy::did(Enter|Exit)Fullscreen`, such that we implement
`didExitFullscreen(PlaybackSessionContextIdentifier)` in the case where
`ENABLE(VIDEO_PRESENTATION_MODE)` is enabled, and `didExitFullscreen()` (with no arguments) in the
case where it's disabled.

Currently both versions of `did(Enter|Exit)Fullscreen()` exist if `ENABLE(VIDEO_PRESENTATION_MODE)`
is set, even though we only expect to call into `did(Enter|Exit)Fullscreen()` from outside of
`WebPageProxy`.

* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didEnterFullscreen):
(WebKit::PageClientImpl::didExitFullscreen):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didEnterFullscreen]):
(-[WKContentView _didExitFullscreen]):
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:

Canonical link: https://commits.webkit.org/251147@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@whsieh whsieh self-assigned this May 31, 2022
@whsieh whsieh added Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebKit Nightly Build labels May 31, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 31, 2022
@whsieh
Copy link
Member Author

whsieh commented May 31, 2022

Thanks for the review!

@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 31, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 5771692 into WebKit:main May 31, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295052 (251147@main): https://commits.webkit.org/251147@main

Reviewed commits have been landed. Closing PR #1168 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
3 participants