Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary vector copies in RemoteLayerTreeTransaction #11691

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Remove unnecessary vector copies in RemoteLayerTreeTransaction #11691

merged 1 commit into from
Mar 20, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Mar 19, 2023 •
edited by webkit-early-warning-system

11d1eb5

Remove unnecessary vector copies in RemoteLayerTreeTransaction
https://bugs.webkit.org/show_bug.cgi?id=254130
rdar://106907403

Reviewed by Simon Fraser.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::createdLayers const):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers const):
(WebKit::RemoteLayerTreeTransaction::layerIDsWithNewlyUnreachableBackingStore const):

Canonical link: https://commits.webkit.org/261889@main

33ec6a7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@achristensen07 achristensen07 self-assigned this Mar 19, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 19, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 33ec6a7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2023
@achristensen07
Remove unnecessary vector copies in RemoteLayerTreeTransaction
11d1eb5 
https://bugs.webkit.org/show_bug.cgi?id=254130
rdar://106907403

Reviewed by Simon Fraser.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::createdLayers const):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers const):
(WebKit::RemoteLayerTreeTransaction::layerIDsWithNewlyUnreachableBackingStore const):

Canonical link: https://commits.webkit.org/261889@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-unnecessary-vector-copies-in-RemoteLayerTreeTransaction branch from 33ec6a7 to 11d1eb5 Compare March 20, 2023 21:00
@webkit-commit-queue webkit-commit-queue merged commit 11d1eb5 into WebKit:main Mar 20, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261889@main (11d1eb5): https://commits.webkit.org/261889@main

Reviewed commits have been landed. Closing PR #11691 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@achristensen07 achristensen07

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @smfr