Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _managedMediaSourceEnabled to WKPreferencesPrivate #11692

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Add _managedMediaSourceEnabled to WKPreferencesPrivate #11692

merged 1 commit into from
Mar 19, 2023

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Mar 19, 2023 •
edited by webkit-early-warning-system

869566c

Add _managedMediaSourceEnabled to WKPreferencesPrivate
https://bugs.webkit.org/show_bug.cgi?id=254124
rdar://106905466

Reviewed by Jer Noble.

* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setManagedMediaSourceEnabled:]):
(-[WKPreferences _managedMediaSourceEnabled]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/261845@main

5220a89

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jyavenard jyavenard requested a review from cdumez as a code owner March 19, 2023 06:10
@jyavenard jyavenard self-assigned this Mar 19, 2023
@jyavenard jyavenard added the Media Bugs related to the HTML 5 Media elements. label Mar 19, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5220a89)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Mar 19, 2023
@jyavenard
Add _managedMediaSourceEnabled to WKPreferencesPrivate
869566c 
https://bugs.webkit.org/show_bug.cgi?id=254124
rdar://106905466

Reviewed by Jer Noble.

* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setManagedMediaSourceEnabled:]):
(-[WKPreferences _managedMediaSourceEnabled]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/261845@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-_managedMediaSourceEnabled-to-WKPreferencesPrivate branch from 5220a89 to 869566c Compare March 19, 2023 21:44
@webkit-commit-queue
Copy link
Collaborator

Committed 261845@main (869566c): https://commits.webkit.org/261845@main

Reviewed commits have been landed. Closing PR #11692 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 869566c into WebKit:main Mar 19, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernoble jernoble jernoble approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@jyavenard jyavenard

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@jyavenard @webkit-early-warning-system @webkit-commit-queue @jernoble