Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimizations to EventDispatcher::dispatchEvent() #11721

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Minor optimizations to EventDispatcher::dispatchEvent() #11721

merged 1 commit into from
Mar 21, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 20, 2023 •
edited by webkit-early-warning-system

3e45e63

Minor optimizations to EventDispatcher::dispatchEvent()
https://bugs.webkit.org/show_bug.cgi?id=254170

Reviewed by Darin Adler.

Minor optimizations to EventDispatcher::dispatchEvent():
- Use a bool instead of a std::optional<bool> for shouldClearTargetsAfterDispatch
  since we don't need 3 states.
- Minimize calls to `event.type() == eventNames().clickEvent` since `eventNames()`
  is not super cheap.
- Minimize calls to shouldSuppressEventDispatchInDOM() and avoid calling
  `event.stopPropagation()` when this function returns true. We can factor the
  `if` check so that setting the stop propagation flag on the event is not actually
  necessary. Note that we call `resetAfterDispatch()` on the event shortly after,
  which resets the stop propagation flag anyway.

* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

Canonical link: https://commits.webkit.org/261906@main

7077d40

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Mar 20, 2023
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Mar 20, 2023
@cdumez cdumez changed the title Minors optimizations to EventDispatcher::dispatchEvent() Minor optimizations to EventDispatcher::dispatchEvent() Mar 20, 2023
@cdumez cdumez force-pushed the 254170_EventDispatcher_dispatchEvent branch from 66330fd to 7077d40 Compare March 20, 2023 19:59
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7077d40)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review March 20, 2023 23:32
@cdumez cdumez requested a review from rniwa as a code owner March 20, 2023 23:32
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 21, 2023
@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 21, 2023
@cdumez
Minor optimizations to EventDispatcher::dispatchEvent()
3e45e63 
https://bugs.webkit.org/show_bug.cgi?id=254170

Reviewed by Darin Adler.

Minor optimizations to EventDispatcher::dispatchEvent():
- Use a bool instead of a std::optional<bool> for shouldClearTargetsAfterDispatch
  since we don't need 3 states.
- Minimize calls to `event.type() == eventNames().clickEvent` since `eventNames()`
  is not super cheap.
- Minimize calls to shouldSuppressEventDispatchInDOM() and avoid calling
  `event.stopPropagation()` when this function returns true. We can factor the
  `if` check so that setting the stop propagation flag on the event is not actually
  necessary. Note that we call `resetAfterDispatch()` on the event shortly after,
  which resets the stop propagation flag anyway.

* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

Canonical link: https://commits.webkit.org/261906@main
@webkit-commit-queue webkit-commit-queue force-pushed the 254170_EventDispatcher_dispatchEvent branch from 7077d40 to 3e45e63 Compare March 21, 2023 02:23
@webkit-commit-queue webkit-commit-queue merged commit 3e45e63 into WebKit:main Mar 21, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261906@main (3e45e63): https://commits.webkit.org/261906@main

Reviewed commits have been landed. Closing PR #11721 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot