Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gstreamer][WebRTC] webrtc/video-disabled-black.html fails #11759

Merged
merged 1 commit into from Mar 22, 2023

Conversation

philn
Copy link
Member

@philn philn commented Mar 21, 2023

aff28bc

[Gstreamer][WebRTC] webrtc/video-disabled-black.html fails
https://bugs.webkit.org/show_bug.cgi?id=254212

Reviewed by Xabier Rodriguez-Calvar.

Flushing a disabled video track would lead to a caps negotiation failure afterwards, so flush only
if the track is being re-enabled.

The webrtc/video-disabled-black.html test was also rewritten in order to avoid flakiness, we now
check the video at most 200 times instead of one, before failing the test.

Also drive-by in MediaStreamSource, rebuild black frame caps when needed, instead of attempting to
update caps that are not writable.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/webrtc/routines.js:
* LayoutTests/webrtc/video-disabled-black.html:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/261951@main

8f8b6ee

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac ⏳ πŸ›  wpe βœ… πŸ›  wincairo
⏳ πŸ§ͺ bindings βœ… πŸ›  ios-sim ⏳ πŸ›  mac-AS-debug ⏳ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl ⏳ πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
⏳ πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim ⏳ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
❌ πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@philn philn self-assigned this Mar 21, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 21, 2023
@philn philn requested a review from calvaris March 21, 2023 14:32
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Mar 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=254212

Reviewed by Xabier Rodriguez-Calvar.

Flushing a disabled video track would lead to a caps negotiation failure afterwards, so flush only
if the track is being re-enabled.

The webrtc/video-disabled-black.html test was also rewritten in order to avoid flakiness, we now
check the video at most 200 times instead of one, before failing the test.

Also drive-by in MediaStreamSource, rebuild black frame caps when needed, instead of attempting to
update caps that are not writable.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/webrtc/routines.js:
* LayoutTests/webrtc/video-disabled-black.html:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/261951@main
@webkit-commit-queue
Copy link
Collaborator

Committed 261951@main (aff28bc): https://commits.webkit.org/261951@main

Reviewed commits have been landed. Closing PR #11759 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit aff28bc into WebKit:main Mar 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 22, 2023
@philn philn deleted the eng/254212 branch March 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants