[WPE][GTK] Build broken with ENABLE_VIDEO=OFF after r292252 #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=241119 Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-31 Reviewed by Miguel Gomez and Philippe Normand. * Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: NV12 is listed twice in the DMABufVideoSink's list of supported formats. This is a typo, one of those was supposed to be NV21, a different-but-similar format that works just fine. Canonical link: https://commits.webkit.org/251141@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
aperezdc
added
Tools / Tests
philn
approved these changes
May 31, 2022
https://bugs.webkit.org/show_bug.cgi?id=241123 Reviewed by Philippe Normand. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: Add missing ENABLE(VIDEO) guard. * Source/WebKit/WebProcess/WebPage/WebPage.h: Ditto. Canonical link: https://commits.webkit.org/251142@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
webkit-early-warning-system
force-pushed
the
eng/WPEGTK-Build-broken-with-ENABLE_VIDEOOFF-after-r292252
branch
from
e9ce1a6
to
4fd8a09
Compare
|
Committed r295047 (251142@main): https://commits.webkit.org/251142@main Reviewed commits have been landed. Closing PR #1179 and removing active labels. |
webkit-early-warning-system
removed
the
merge-queue
aperezdc
deleted the
eng/WPEGTK-Build-broken-with-ENABLE_VIDEOOFF-after-r292252
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4fd8a09