Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block unused resources in v3 sandbox #11826

Merged
merged 1 commit into from Mar 24, 2023
Merged

Block unused resources in v3 sandbox #11826

merged 1 commit into from Mar 24, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Mar 22, 2023 •
edited by webkit-early-warning-system

7bd957f

Block unused resources in v3 sandbox
https://bugs.webkit.org/show_bug.cgi?id=254291
rdar://106827256

Reviewed by Brent Fulgham.

Block unused resources in v3 sandbox in the WebContent process on macOS and iOS. For Catalyst, we will
enforce separately.

* Source/WebKit/Shared/Sandbox/common.sb:

Canonical link: https://commits.webkit.org/262058@main

9796a27

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Mar 22, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9796a27)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan
Copy link
Contributor Author

pvollan commented Mar 23, 2023

r=me

Thanks for reviewing!

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2023
@pvollan
Block unused resources in v3 sandbox
7bd957f 
https://bugs.webkit.org/show_bug.cgi?id=254291
rdar://106827256

Reviewed by Brent Fulgham.

Block unused resources in v3 sandbox in the WebContent process on macOS and iOS. For Catalyst, we will
enforce separately.

* Source/WebKit/Shared/Sandbox/common.sb:

Canonical link: https://commits.webkit.org/262058@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Block-unused-resources-in-v3-sandbox branch from 9796a27 to 7bd957f Compare March 24, 2023 05:00
@webkit-commit-queue
Copy link
Collaborator

Committed 262058@main (7bd957f): https://commits.webkit.org/262058@main

Reviewed commits have been landed. Closing PR #11826 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7bd957f into WebKit:main Mar 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham