StyleRuleGroup should use composition instead of inheritance

[mdubet]

f3dde5a

StyleRuleGroup should use composition instead of inheritance
https://bugs.webkit.org/show_bug.cgi?id=254297
rdar://107103847

Reviewed by NOBODY (OOPS!).

The inheritance comes from the CSSGroupingRule spec,
but we have no reason to follow the same pattern/hierarchy in our
internal representation.

* Source/WebCore/css/CSSConditionRule.cpp:
(WebCore::CSSConditionRule::CSSConditionRule):
* Source/WebCore/css/CSSConditionRule.h:
* Source/WebCore/css/CSSContainerRule.cpp:
(WebCore::CSSContainerRule::styleRuleContainer const):
* Source/WebCore/css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::~CSSGroupingRule):
(WebCore::CSSGroupingRule::insertRule):
(WebCore::CSSGroupingRule::deleteRule):
(WebCore::CSSGroupingRule::cssTextForDeclsAndRules const):
(WebCore::CSSGroupingRule::length const):
(WebCore::CSSGroupingRule::item const):
(WebCore::CSSGroupingRule::reattach):
(WebCore::CSSGroupingRule::groupRule const):
(WebCore::CSSGroupingRule::groupRule):
* Source/WebCore/css/CSSGroupingRule.h:
(WebCore::CSSGroupingRule::rule const):
(WebCore::CSSGroupingRule::groupRule const): Deleted.
(WebCore::CSSGroupingRule::groupRule): Deleted.
* Source/WebCore/css/CSSLayerBlockRule.cpp:
(WebCore::CSSLayerBlockRule::name const):
* Source/WebCore/css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::mediaQueries const):
(WebCore::CSSMediaRule::setMediaQueries):
* Source/WebCore/css/CSSSupportsRule.cpp:
(WebCore::CSSSupportsRule::conditionText const):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleGroup::childRules):
(WebCore::StyleRuleGroup::fromStyleRuleBase):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
(WebCore::StyleRuleLayer::StyleRuleLayer):
(WebCore::StyleRuleContainer::StyleRuleContainer):
* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRuleBase::isStyleRuleWithNesting const):
(WebCore::StyleRuleBase::isGroupRule const):
* Source/WebCore/css/StyleSheetContents.cpp:
(WebCore::traverseRulesInVector):
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addChildRule):
* Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::shouldDirtyAllStyle):

f3dde5a

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 13fd3be)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🛠 tv	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv-sim	🧪 mac-AS-debug-wk2
	❌ 🛠 watch	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 85bec4b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🛠 tv	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch-sim

[anttijk]

I feel all this refactoring achieves little. StyleRuleGroup is a trivial helper type that just holds the child rule vector. It has no meaningful functionality.

Also CSSStyleRule in the nesting spec is not a CSSGroupingRule (it just adds insert/deleteRule) so I'm not sure how this is even helps? CSSStyleRule would have all the code dealing with StyleRule/StyleRuleWithNesting and CSSGroupingRule would have the code dealing with StyleRuleGroup.

[mdubet]

Indeed this patch doesn't achieve much but it's a small step forward to fix some inconsistencies in the codebase by removing StyleRuleGroup from the Rule hierarchy (StyleRuleGroup is not a Rule and should not inherit from StyleRuleBase).

The CSSGroupingRule discussion is for another PR, we should try to consider them separately.

[webkit-early-warning-system]

EWS run on current version of this PR (hash f3dde5a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim