Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid HashSet copy in DocumentTimeline::applyPendingAcceleratedAnimations() #11844

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Avoid HashSet copy in DocumentTimeline::applyPendingAcceleratedAnimations() #11844

merged 1 commit into from
Mar 23, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 23, 2023 •
edited by webkit-early-warning-system

821a561

Avoid HashSet copy in DocumentTimeline::applyPendingAcceleratedAnimations()
https://bugs.webkit.org/show_bug.cgi?id=254308

Reviewed by Ryosuke Niwa.

* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):

Canonical link: https://commits.webkit.org/262007@main

4aa0f9e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez requested a review from graouts as a code owner March 23, 2023 02:49
@cdumez cdumez self-assigned this Mar 23, 2023
@cdumez cdumez added the Animations Bugs related to CSS + SVG animations and transitions label Mar 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4aa0f9e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2023
@cdumez
Avoid HashSet copy in DocumentTimeline::applyPendingAcceleratedAnimat…
821a561 
…ions()

https://bugs.webkit.org/show_bug.cgi?id=254308

Reviewed by Ryosuke Niwa.

* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):

Canonical link: https://commits.webkit.org/262007@main
@webkit-commit-queue webkit-commit-queue force-pushed the 254308_applyPendingAcceleratedAnimations branch from 4aa0f9e to 821a561 Compare March 23, 2023 05:22
@webkit-commit-queue
Copy link
Collaborator

Committed 262007@main (821a561): https://commits.webkit.org/262007@main

Reviewed commits have been landed. Closing PR #11844 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 821a561 into WebKit:main Mar 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@graouts graouts Awaiting requested review from graouts graouts is a code owner

@darinadler darinadler Awaiting requested review from darinadler

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa