Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LibWebRTC] Fix build with CMake >= 3.26 #11858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[LibWebRTC] Fix build with CMake >= 3.26 #11858

wants to merge 1 commit into from

Conversation

hwti
Copy link
Contributor

@hwti hwti commented Mar 23, 2023 •
edited by webkit-early-warning-system

e23fe1f

[LibWebRTC] Fix build with CMake >= 3.26
https://bugs.webkit.org/show_bug.cgi?id=254323

Reviewed by NOBODY (OOPS!).

Starting from CMake 3.26, the flags from CMAKE_CXX_STANDARD are moved
before the ones from target_compile_options, so libwebrtc is compiled
in C++11 instead of the default C++20.
It fails in Source/third_party/abseil-cpp/absl/base/policy_checks.h,
which wants C++14.

e23fe1f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@hwti
[LibWebRTC] Fix build with CMake >= 3.26
e23fe1f 
https://bugs.webkit.org/show_bug.cgi?id=254323

Reviewed by NOBODY (OOPS!).

Starting from CMake 3.26, the flags from CMAKE_CXX_STANDARD are moved
before the ones from target_compile_options, so libwebrtc is compiled
in C++11 instead of the default C++20.
It fails in Source/third_party/abseil-cpp/absl/base/policy_checks.h,
which wants C++14.
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e23fe1f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 23, 2023
@hwti
Copy link
Contributor Author

hwti commented Mar 23, 2023

cc @alexgcastro @youennf (from d6dd8ba which added the -std=gnu++11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merging-blocked Applied to prevent a change from being merged
Projects
None yet
Milestone
No milestone
3 participants
@hwti @webkit-early-warning-system @webkit-ews-buildbot