New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on piped ReadableStream leads to Unhandled Promise Rejection #11864
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
youennf:eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
Mar 27, 2023
Merged
Error on piped ReadableStream leads to Unhandled Promise Rejection #11864
webkit-commit-queue
merged 1 commit into
WebKit:main
from
youennf:eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
the
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
label
Mar 23, 2023
EWS run on previous version of this PR (hash 5465e96) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Mar 23, 2023
youennf
force-pushed
the
eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
branch
from
March 23, 2023 16:48
5465e96
to
a982ed8
Compare
EWS run on previous version of this PR (hash a982ed8) |
youennf
force-pushed
the
eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
branch
from
March 24, 2023 09:38
a982ed8
to
1a6cbd8
Compare
EWS run on previous version of this PR (hash 1a6cbd8) |
youennf
force-pushed
the
eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
branch
from
March 24, 2023 12:05
1a6cbd8
to
0e79d9e
Compare
EWS run on current version of this PR (hash 0e79d9e) |
youennf
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Mar 24, 2023
achristensen07
approved these changes
Mar 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=251463 rdar://problem/105149496 Reviewed by Alex Christensen. The closed promise can be rejected in which case we do not need to do anything, except make sure the promise is handled. Replacing undefined by an empty function to make it handled. Ditto for pendingWritePromise since we want to react on promise settlement, no matter whether resolved or rejected. This only impacts unhandled promise rejection code since eithwe we ignore the promise altogether, or the current code is using the same handler for fulfillment and rejection. Removing some GLIB specifc test expectations as they should be the same as the base ones. * LayoutTests/imported/w3c/web-platform-tests/streams/piping/abort.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/abort.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/abort.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/abort.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/flow-control.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/flow-control.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/flow-control.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/flow-control.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/abort.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/flow-control.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/general.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/streams/piping/pipe-through.any-expected.txt: Removed. * LayoutTests/streams/pipeTo-unhandled-promise-expected.txt: Added. * LayoutTests/streams/pipeTo-unhandled-promise.html: Added. * Source/WebCore/Modules/streams/ReadableStreamInternals.js: (pipeToClosingMustBePropagatedForward): (pipeToClosingMustBePropagatedBackward): Deleted. Canonical link: https://commits.webkit.org/262137@main
webkit-commit-queue
force-pushed
the
eng/Error-on-piped-ReadableStream-leads-to-Unhandled-Promise-Rejection
branch
from
March 27, 2023 07:25
0e79d9e
to
3a75b5d
Compare
Committed 262137@main (3a75b5d): https://commits.webkit.org/262137@main Reviewed commits have been landed. Closing PR #11864 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3a75b5d
0e79d9e