Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Quiet pkgconfig output #11881

Merged
merged 1 commit into from Mar 24, 2023
Merged

[CMake] Quiet pkgconfig output #11881

merged 1 commit into from Mar 24, 2023

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Mar 23, 2023 •
edited by webkit-early-warning-system

29ca353

[CMake] Quiet pkgconfig output
https://bugs.webkit.org/show_bug.cgi?id=254365

Reviewed by Michael Catanzaro.

When using `find_package` for pkgconfig use `QUIET` output. When using
`pkg_check_modules` use `QUIET` output.

Canonical link: https://commits.webkit.org/262048@main

d5379fc

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🧪 jsc-mips-tests

@donny-dont donny-dont self-assigned this Mar 23, 2023
@donny-dont donny-dont added the CMake Bugzilla component for CMake build system changes label Mar 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 8e6e0d8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ❌ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
  🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🧪 jsc-mips-tests

@donny-dont donny-dont added the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Mar 23, 2023
@donny-dont donny-dont added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 23, 2023
@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Mar 23, 2023
@donny-dont donny-dont added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Mar 23, 2023
@donny-dont donny-dont force-pushed the eng/CMake-Quiet-pkgconfig-output branch from 8e6e0d8 to d5379fc Compare March 23, 2023 23:15
@donny-dont donny-dont added the merge-queue Applied to send a pull request to merge-queue label Mar 23, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d5379fc)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🧪 jsc-mips-tests

@donny-dont
[CMake] Quiet pkgconfig output
29ca353 
https://bugs.webkit.org/show_bug.cgi?id=254365

Reviewed by Michael Catanzaro.

When using `find_package` for pkgconfig use `QUIET` output. When using
`pkg_check_modules` use `QUIET` output.

Canonical link: https://commits.webkit.org/262048@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262048@main (29ca353): https://commits.webkit.org/262048@main

Reviewed commits have been landed. Closing PR #11881 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 29ca353 into WebKit:main Mar 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@aperezdc aperezdc Awaiting requested review from aperezdc

Assignees

@donny-dont donny-dont

Labels
CMake Bugzilla component for CMake build system changes
Projects
None yet
Milestone
No milestone
5 participants
@donny-dont @webkit-early-warning-system @webkit-commit-queue @mcatanzaro @webkit-ews-buildbot