[MSE] media/media-source/media-source-video-playback-quality.html is a constant failure with MockMSE in GPUP #11915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 84e4339)
|
jyavenard
changed the title
|
s/we must the entire content first./we must get the entire content first./ |
youennf
approved these changes
Mar 24, 2023
| run('source.endOfStream()'); | ||
| run('video.play()'); | ||
| await waitFor(video, 'ended'); | ||
| setTimeout(videoEnded, 50); // VideoPlaybackQuality is refreshed every 0.25s, wait a bit. |
There was a problem hiding this comment.
Isn't there a risk for flakiness?
Should we do the try test and if failing retry until 100 times approach?
There was a problem hiding this comment.
I'm not familiar with this. What if 100 loops is done under 0.25s?
There was a problem hiding this comment.
Actually, with our current implementation there's no risk of flakiness:
- With WK1 or WK2 with MockMSE in the CP, the object is updated synchronously when you call
getVideoPlaybackQuality() - With the MockMSE in the GPU Process, the VPQ is updated in the next event loop
void RemoteMediaPlayerProxy::updateCachedState(bool forceCurrentTimeUpdate)
{
if (!m_observingTimeChanges || forceCurrentTimeUpdate)
currentTimeChanged(m_player->currentTime());
m_cachedState.paused = m_player->paused();
maybeUpdateCachedVideoMetrics();
if (m_bufferedChanged) {
m_bufferedChanged = false;
if ((m_engineIdentifier != MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE)
&& (m_engineIdentifier != MediaPlayerEnums::MediaEngineIdentifier::MockMSE)) {
m_cachedState.bufferedRanges = *m_player->buffered();
}
}
}
it sends the time , and immediately after the player state, which contains the VPQ
jyavenard
force-pushed
the
eng/MSE-mediamedia-sourcemedia-source-video-playback-quality-html-is-a-constant-failure-with-MockMSE-in-GPUP
branch
from
84e4339
to
36a5457
Compare
|
EWS run on current version of this PR (hash 36a5457)
|
…a constant failure with MockMSE in GPUP https://bugs.webkit.org/show_bug.cgi?id=254405 rdar://107182984 Reviewed by Youenn Fablet. To get a valid VideoPlaybackQuality object about all the frames contained in the SourceBuffer we must get the entire content first. We modify the test so that the video is played to the end first and only then get the VideoPlaybackQuality. * LayoutTests/media/media-source/media-source-video-playback-quality-expected.txt: * LayoutTests/media/media-source/media-source-video-playback-quality.html: Canonical link: https://commits.webkit.org/262071@main
webkit-commit-queue
force-pushed
the
eng/MSE-mediamedia-sourcemedia-source-video-playback-quality-html-is-a-constant-failure-with-MockMSE-in-GPUP
branch
from
36a5457
to
ad2552f
Compare
|
Committed 262071@main (ad2552f): https://commits.webkit.org/262071@main Reviewed commits have been landed. Closing PR #11915 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ad2552f
36a5457
🧪 wpe-wk2🧪 ios-wk2🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🧪 mac-AS-debug-wk2