[WGSL] Textures and samplers shouldn't be references

[tadeuzagallo]

889edf2

[WGSL] Textures and samplers shouldn't be references
https://bugs.webkit.org/show_bug.cgi?id=254425
rdar://107188253

Reviewed by Myles C. Maxfield.

When converting globals to argument buffers, most values become references, but
that doesn't apply to textures and samplers. Add logic to check the type of the
global instead of unconditionally converting it to a reference.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/262200@main

c248a69

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash c248a69)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[litherum]

I think this is the right design, but how confident are we that this actually works on all metal devices that we support? The output program would be something like

kernel void foo(texture2d<float> foo) {
    ...
    texture2d<float> bar = foo;
    ...
}

I guess I should try to do the research to make sure this actually works everywhere.

[litherum]

Looks like yes this is supposed to work everywhere.

[djg]

[webkit-commit-queue]

Committed 262200@main (889edf2): https://commits.webkit.org/262200@main

Reviewed commits have been landed. Closing PR #11929 and removing active labels.