[WGSL] Add overloads for textureSample #11934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash bc70c1d)
|
djg
approved these changes
Mar 25, 2023
| @@ -11,3 +11,17 @@ | |||
| [T < Float, C, R].(Matrix[T, C, R], Vector[T, C]) => Vector[T, R], | |||
| [T < Float, C, R].(Vector[T, R], Matrix[T, C, R]) => Vector[T, C], | |||
| } | |||
|
|
|||
| operator :textureSample, { | |||
There was a problem hiding this comment.
Can we document the missing textureSample functions with a FIXME?
There was a problem hiding this comment.
I added a link to a bugzilla bug that lists all the missing overloads
|
EWS run on previous version of this PR (hash 8f5e896)
|
tadeuzagallo
force-pushed
the
eng/WGSL-Add-overloads-for-textureSample
branch
2 times, most recently
from
8f5e896
to
803292f
Compare
|
EWS run on current version of this PR (hash 803292f)
|
https://bugs.webkit.org/show_bug.cgi?id=254431 rdar://107190590 Reviewed by Myles C. Maxfield. Add the definitions for the overloads of textureSample that operate on non-depth textures. This requires minor modifications to the DSL to support concrete instances of types that can also be abstract (i.e. Vector and Matrix). The definitions are a little hard to read, and I might revisit it soon, but for now it matches the existing definitions. * Source/WebGPU/WGSL/Overload.h: * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/generator/main.rb: Canonical link: https://commits.webkit.org/262204@main
webkit-commit-queue
force-pushed
the
eng/WGSL-Add-overloads-for-textureSample
branch
from
803292f
to
9b4dfec
Compare
|
Committed 262204@main (9b4dfec): https://commits.webkit.org/262204@main Reviewed commits have been landed. Closing PR #11934 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9b4dfec
803292f
🧪 ios-wk2🧪 api-ios🧪 gtk-wk2🧪 mac-AS-debug-wk2