Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadableStreamError should reject closed promise before erroring read promises #11997

Merged
merged 1 commit into from Mar 27, 2023
Merged

ReadableStreamError should reject closed promise before erroring read promises #11997

merged 1 commit into from Mar 27, 2023

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Mar 27, 2023 •
edited by webkit-early-warning-system

1f74c15

ReadableStreamError should reject closed promise before erroring read promises
https://bugs.webkit.org/show_bug.cgi?id=254509
rdar://problem/107262301

Reviewed by Alex Christensen.

Update implementation as per latest version of https://streams.spec.whatwg.org/#readable-stream-error.

* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.worker-expected.txt:
* LayoutTests/streams/readable-stream-default-reader-read.html:
* Source/WebCore/Modules/streams/ReadableStreamInternals.js:
(readableStreamError):

Canonical link: https://commits.webkit.org/262164@main

ceeb586

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@youennf youennf self-assigned this Mar 27, 2023
@youennf youennf added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Mar 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 9f9de40)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 27, 2023
@youennf youennf removed the merging-blocked Applied to prevent a change from being merged label Mar 27, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 27, 2023
@youennf youennf force-pushed the eng/ReadableStreamError-should-reject-closed-promise-before-erroring-read-promises branch from 9f9de40 to ceeb586 Compare March 27, 2023 14:04
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ceeb586)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@youennf youennf removed the merging-blocked Applied to prevent a change from being merged label Mar 27, 2023
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Mar 27, 2023
@youennf
ReadableStreamError should reject closed promise before erroring read…
1f74c15 
… promises

https://bugs.webkit.org/show_bug.cgi?id=254509
rdar://problem/107262301

Reviewed by Alex Christensen.

Update implementation as per latest version of https://streams.spec.whatwg.org/#readable-stream-error.

* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.worker-expected.txt:
* LayoutTests/streams/readable-stream-default-reader-read.html:
* Source/WebCore/Modules/streams/ReadableStreamInternals.js:
(readableStreamError):

Canonical link: https://commits.webkit.org/262164@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ReadableStreamError-should-reject-closed-promise-before-erroring-read-promises branch from ceeb586 to 1f74c15 Compare March 27, 2023 18:30
@webkit-commit-queue
Copy link
Collaborator

Committed 262164@main (1f74c15): https://commits.webkit.org/262164@main

Reviewed commits have been landed. Closing PR #11997 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1f74c15 into WebKit:main Mar 27, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees

@youennf youennf

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@youennf @webkit-early-warning-system @webkit-commit-queue @achristensen07 @webkit-ews-buildbot