Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPEToolingsBackend requires linking against libgobject #1207

Conversation

zdobersek
Copy link
Contributor

@zdobersek zdobersek commented Jun 1, 2022

ab03824

WPEToolingsBackend requires linking against libgobject
https://bugs.webkit.org/show_bug.cgi?id=241180

Patch by Žan Doberšek <zdobersek@igalia.com > on 2022-06-01
Unreviewed, WPEToolingsBackend library should link against the GObject library
as required by ATK code, avoiding linking issues that only pop up at the point
of linking the WebKitTestRunner binary, and in only some specific
configurations.

* Tools/wpe/backends/PlatformWPE.cmake:
Have the WPEToolingsBackend link against GObject libraries.

Canonical link: https://commits.webkit.org/251180@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@zdobersek zdobersek self-assigned this Jun 1, 2022
@zdobersek zdobersek added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. Other unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 1, 2022
https://bugs.webkit.org/show_bug.cgi?id=241180

Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-06-01
Unreviewed, WPEToolingsBackend library should link against the GObject library
as required by ATK code, avoiding linking issues that only pop up at the point
of linking the WebKitTestRunner binary, and in only some specific
configurations.

* Tools/wpe/backends/PlatformWPE.cmake:
Have the WPEToolingsBackend link against GObject libraries.

Canonical link: https://commits.webkit.org/251180@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WPEToolingsBackend-requires-linking-against-libgobject branch from 8c6db12 to ab03824 Compare June 1, 2022 11:05
@webkit-early-warning-system
Copy link
Collaborator

Committed r295085 (251180@main): https://commits.webkit.org/251180@main

Reviewed commits have been landed. Closing PR #1207 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 1, 2022
@zdobersek zdobersek deleted the eng/WPEToolingsBackend-requires-linking-against-libgobject branch August 22, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
2 participants