Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use originSaltFileName to create salt file path in CacheStorageManger #12146

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Always use originSaltFileName to create salt file path in CacheStorageManger #12146

merged 1 commit into from
Mar 31, 2023

Conversation

szewai
Copy link
Contributor

@szewai szewai commented Mar 30, 2023 •
edited by webkit-early-warning-system

e14c57a

Always use originSaltFileName to create salt file path in CacheStorageManger
https://bugs.webkit.org/show_bug.cgi?id=254705
rdar://107393253

Reviewed by Youenn Fablet.

* Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp:
(WebKit::saltFilePath):
(WebKit::readOrMakeSalt):
(WebKit::CacheStorageManager::cacheStorageOriginDirectory):
(WebKit::CacheStorageManager::copySaltFileToOriginDirectory):
(WebKit::CacheStorageManager::CacheStorageManager):

Canonical link: https://commits.webkit.org/262410@main

c132c95

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@szewai szewai requested a review from cdumez as a code owner March 30, 2023 00:02
@szewai szewai self-assigned this Mar 30, 2023
@szewai szewai added the Website Storage Bugs related to storage APIs, including IndexedDB and localStorage label Mar 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c132c95)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@szewai szewai requested a review from youennf March 30, 2023 16:32
@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2023
@szewai
Always use originSaltFileName to create salt file path in CacheStorag…
e14c57a 
…eManger

https://bugs.webkit.org/show_bug.cgi?id=254705
rdar://107393253

Reviewed by Youenn Fablet.

* Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp:
(WebKit::saltFilePath):
(WebKit::readOrMakeSalt):
(WebKit::CacheStorageManager::cacheStorageOriginDirectory):
(WebKit::CacheStorageManager::copySaltFileToOriginDirectory):
(WebKit::CacheStorageManager::CacheStorageManager):

Canonical link: https://commits.webkit.org/262410@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Always-use-originSaltFileName-to-create-salt-file-path-in-CacheStorageManger branch from c132c95 to e14c57a Compare March 31, 2023 16:32
@webkit-commit-queue
Copy link
Collaborator

Committed 262410@main (e14c57a): https://commits.webkit.org/262410@main

Reviewed commits have been landed. Closing PR #12146 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e14c57a into WebKit:main Mar 31, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@szewai szewai

Labels
Website Storage Bugs related to storage APIs, including IndexedDB and localStorage
Projects
None yet
Milestone
No milestone
4 participants
@szewai @webkit-early-warning-system @webkit-commit-queue @youennf