Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebXR should be considered a foreground session for view visibility purposes #12147

Merged
merged 1 commit into from
Mar 30, 2023
Merged

WebXR should be considered a foreground session for view visibility purposes #12147

merged 1 commit into from
Mar 30, 2023

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented Mar 30, 2023 •
edited by webkit-early-warning-system

fcb8eb9

WebXR should be considered a foreground session for view visibility purposes
https://bugs.webkit.org/show_bug.cgi?id=254709
rdar://106763470

Reviewed by Dean Jackson.

* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible):
In order to ensure that navigations stay at foreground priority, keep the view visible.

Canonical link: https://commits.webkit.org/262306@main

077fd28

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@hortont424 hortont424 requested a review from cdumez as a code owner March 30, 2023 00:23
@hortont424 hortont424 self-assigned this Mar 30, 2023
@hortont424 hortont424 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 077fd28)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label Mar 30, 2023
@hortont424
WebXR should be considered a foreground session for view visibility p…
fcb8eb9 
…urposes

https://bugs.webkit.org/show_bug.cgi?id=254709
rdar://106763470

Reviewed by Dean Jackson.

* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible):
In order to ensure that navigations stay at foreground priority, keep the view visible.

Canonical link: https://commits.webkit.org/262306@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebXR-should-be-considered-a-foreground-session-for-view-visibility-purposes branch from 077fd28 to fcb8eb9 Compare March 30, 2023 01:20
@webkit-commit-queue
Copy link
Collaborator

Committed 262306@main (fcb8eb9): https://commits.webkit.org/262306@main

Reviewed commits have been landed. Closing PR #12147 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fcb8eb9 into WebKit:main Mar 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grorg grorg grorg approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@hortont424 hortont424

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@hortont424 @webkit-early-warning-system @webkit-commit-queue @grorg