Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION (iOS 16.4): Form controls are drawn incorrectly when lockdown mode is enabled #12158

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Mar 30, 2023

ca4bed3

REGRESSION (iOS 16.4): Form controls are drawn incorrectly when lockdown mode is enabled
https://bugs.webkit.org/show_bug.cgi?id=254719
rdar://104829495

Reviewed by Wenson Hsieh and Brent Fulgham.

Form controls on iOS were redesigned in iOS 15. To aid with testing and debugging
the `IOSFormControlRefreshEnabled` feature flag was introduced. This flag was
enabled by default in iOS 15.

However, 258448@main miscategorized the feature as "unstable", and as of 257758@main,
all "unstable" features are disabled in lockdown mode. This feature should not
be disabled in any shipping configuration.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Mark the feature as "internal", since it is only intended for debugging purposes,
is not web API, and has shipped in a much older release.

The flag can likely be removed entirely now, however, that is a much larger change
involving a great deal of code removal across many files.

Canonical link: https://commits.webkit.org/262338@main

cd490f1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch-sim βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ§ͺ jsc-mips-tests

@pxlcoder pxlcoder self-assigned this Mar 30, 2023
@pxlcoder pxlcoder added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Mar 30, 2023
@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2023
…own mode is enabled

https://bugs.webkit.org/show_bug.cgi?id=254719
rdar://104829495

Reviewed by Wenson Hsieh and Brent Fulgham.

Form controls on iOS were redesigned in iOS 15. To aid with testing and debugging
the `IOSFormControlRefreshEnabled` feature flag was introduced. This flag was
enabled by default in iOS 15.

However, 258448@main miscategorized the feature as "unstable", and as of 257758@main,
all "unstable" features are disabled in lockdown mode. This feature should not
be disabled in any shipping configuration.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Mark the feature as "internal", since it is only intended for debugging purposes,
is not web API, and has shipped in a much older release.

The flag can likely be removed entirely now, however, that is a much larger change
involving a great deal of code removal across many files.

Canonical link: https://commits.webkit.org/262338@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262338@main (ca4bed3): https://commits.webkit.org/262338@main

Reviewed commits have been landed. Closing PR #12158 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ca4bed3 into WebKit:main Mar 30, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)
Projects
None yet
5 participants