Debug build WebGL tests are slow because they output a lot of result text

[kkinnunen-apple]

138bf28

Debug build WebGL tests are slow because they output a lot of result text
https://bugs.webkit.org/show_bug.cgi?id=254736
rdar://107415745

Reviewed by Alexey Proskuryakov.

Load the WebGL conformance tests in quiet mode. This avoids adding the results
to the DOM inside the iframe. WebKit StringView implementation is slowing the tests
with large amount of result prints on Debug. This causes excessive timeouts.

The results are shown for tests that complete via the wrapping test harness.
The results are not shown if the test has a syntax error. These should be debuggable
simply without test result lines in the bot results. In mysterious cases, the quiet
parameter can be removed from individual test runner wrappers temporarily.

* LayoutTests/http/tests/webgl/1.0.x/conformance/more/functions/readPixelsBadArgs.html:
* LayoutTests/http/tests/webgl/1.0.x/conformance/more/functions/texImage2DHTML.html:
* LayoutTests/http/tests/webgl/1.0.x/conformance/more/functions/texSubImage2DHTML.html:
* LayoutTests/http/tests/webgl/1.0.x/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html:
* LayoutTests/http/tests/webgl/1.0.x/conformance/textures/misc/origin-clean-conformance.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance/more/functions/readPixelsBadArgs.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance/more/functions/texImage2DHTML.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance/more/functions/texSubImage2DHTML.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance/textures/misc/origin-clean-conformance.html:
* LayoutTests/http/tests/webgl/2.0.y/conformance2/textures/misc/origin-clean-conformance-offscreencanvas.html:
* LayoutTests/http/tests/webgl/resources/webkit-webgl-test-harness.js:
(window.webglTestHarness.reportResults):
(window.webglTestHarness.notifyFinished):
(list): Deleted.
* LayoutTests/webgl/1.0.x/conformance/attribs/gl-bindAttribLocation-aliasing.html:
* LayoutTests/webgl/1.0.x/conformance/attribs/gl-bindAttribLocation-matrix.html:
* LayoutTests/webgl/1.0.x/conformance/attribs/gl-bindAttribLocation-nonexistent-attribute.html:

... a lot of tests omitted ...

* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.output_type.unsigned_byte.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.output_type.unsigned_int.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.output_type.unsigned_int_2_10_10_10.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.output_type.unsigned_short.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.stride.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.dynamic_copy.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.dynamic_draw.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.dynamic_read.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.static_copy.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.static_draw.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.static_read.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.stream_copy.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.stream_draw.html:
* LayoutTests/webgl/2.0.y/deqp/functional/gles3/vertexarrays/single_attribute.usage.stream_read.html:
* Tools/Scripts/webkitpy/update_webgl_conformance_tests_lib/main.py:
* Tools/Scripts/webkitpy/update_webgl_conformance_tests_lib/webgl-expectation-template.txt:
* Tools/Scripts/webkitpy/update_webgl_conformance_tests_lib/webgl-test-driver-template.html:
* Tools/Scripts/webkitpy/update_webgl_conformance_tests_lib/webkit-webgl-test-harness-template.js:
(window.webglTestHarness.reportResults):
(window.webglTestHarness.notifyFinished):
(list): Deleted.

Canonical link: https://commits.webkit.org/262387@main

60ba3bb

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash e333d71)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	✅ 🛠 gtk
	🧪 api-ios	🧪 mac-wk1	🧪 gtk-wk2
	✅ 🛠 tv	🧪 mac-wk2	🧪 api-gtk
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 60ba3bb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[aproskuryakov]

Are those debug assertions slowing it down, or just lack of optimization? If it's the former, have you considered removing those? They likely make other tests slower, even if not so dramatically.

[kkinnunen-apple]

Are those debug assertions slowing it down, or just lack of optimization? If it's the former, have you considered removing those? They likely make other tests slower, even if not so dramatically.

Definitively they should be making other tests slow, too.
I filed:
https://bugs.webkit.org/show_bug.cgi?id=254730

I can fix ~50% of the problem, but to get better perf we'd need a bit of WTF::String/StringImpl fixes.

[webkit-commit-queue]

Committed 262387@main (138bf28): https://commits.webkit.org/262387@main

Reviewed commits have been landed. Closing PR #12172 and removing active labels.