Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI-side compositing] Have RemoteLayerTreeScrollingPerformanceData log data after each event #12180

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[UI-side compositing] Have RemoteLayerTreeScrollingPerformanceData log data after each event #12180

merged 1 commit into from
Mar 30, 2023

Conversation

nmoucht
Copy link
Contributor

@nmoucht nmoucht commented Mar 30, 2023 •
edited by webkit-early-warning-system

715676d

[UI-side compositing] Have RemoteLayerTreeScrollingPerformanceData log data after each event
https://bugs.webkit.org/show_bug.cgi?id=254747
rdar://107424375

Reviewed by Simon Fraser.

Have RemoteLayerTreeScrollingPerformanceData log data after each event to stop ScrollPerf
from crashing due to no scrolling data.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm:
(WebKit::RemoteLayerTreeScrollingPerformanceData::didCommitLayerTree):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didScroll):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didChangeSynchronousScrollingReasons):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::logScrollingPerformanceData): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/262378@main

1288d3e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@nmoucht nmoucht requested a review from cdumez as a code owner March 30, 2023 16:36
@nmoucht nmoucht self-assigned this Mar 30, 2023
@nmoucht nmoucht added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d7982f5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@nmoucht nmoucht requested a review from smfr March 30, 2023 16:36
@nmoucht nmoucht force-pushed the eng/UI-side-compositing-Have-RemoteLayerTreeScrollingPerformanceData-log-data-after-each-event branch from d7982f5 to 1288d3e Compare March 30, 2023 22:12
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1288d3e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@smfr smfr added skip-ews Applied to prevent a change from being run on EWS and removed skip-ews Applied to prevent a change from being run on EWS labels Mar 30, 2023
@nmoucht nmoucht added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2023
@nmoucht
[UI-side compositing] Have RemoteLayerTreeScrollingPerformanceData lo…
715676d 
…g data after each event

https://bugs.webkit.org/show_bug.cgi?id=254747
rdar://107424375

Reviewed by Simon Fraser.

Have RemoteLayerTreeScrollingPerformanceData log data after each event to stop ScrollPerf
from crashing due to no scrolling data.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm:
(WebKit::RemoteLayerTreeScrollingPerformanceData::didCommitLayerTree):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didScroll):
(WebKit::RemoteLayerTreeScrollingPerformanceData::didChangeSynchronousScrollingReasons):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::logScrollingPerformanceData): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/262378@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UI-side-compositing-Have-RemoteLayerTreeScrollingPerformanceData-log-data-after-each-event branch from 1288d3e to 715676d Compare March 30, 2023 23:58
@webkit-commit-queue
Copy link
Collaborator

Committed 262378@main (715676d): https://commits.webkit.org/262378@main

Reviewed commits have been landed. Closing PR #12180 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 715676d into WebKit:main Mar 30, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@nmoucht nmoucht

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@nmoucht @webkit-early-warning-system @webkit-commit-queue @smfr