Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share more code between local and remote postMessage #12201

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Mar 30, 2023

3d36d22

Share more code between local and remote postMessage
https://bugs.webkit.org/show_bug.cgi?id=254773

Reviewed by Chris Dumez.

Share the shape all the way down to the IDL.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::createTargetOriginForPostMessage):
* Source/WebCore/page/DOMWindow.h:
(WebCore::DOMWindow::identifier const):
* Source/WebCore/page/DOMWindow.idl: Copied from Source/WebCore/page/DOMWindow.h.
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::postMessage):
* Source/WebCore/page/LocalDOMWindow.h:
(WebCore::WindowPostMessageOptions::WindowPostMessageOptions): Deleted.
* Source/WebCore/page/LocalDOMWindow.idl:
* Source/WebCore/page/RemoteDOMWindow.cpp:
(WebCore::RemoteDOMWindow::postMessage):
* Source/WebCore/page/RemoteDOMWindow.h:
* Source/WebCore/page/RemoteDOMWindow.idl:
* Source/WebCore/page/WindowPostMessageOptions.h: Copied from Source/WebCore/page/DOMWindow.h.
(WebCore::WindowPostMessageOptions::WindowPostMessageOptions):
* Source/WebCore/page/WindowPostMessageOptions.idl: Copied from Source/WebCore/page/DOMWindow.h.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/262437@main

8e143d6

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
❌ πŸ›  πŸ§ͺ unsafe-merge

@achristensen07 achristensen07 self-assigned this Mar 30, 2023
@achristensen07 achristensen07 added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Mar 30, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 30, 2023
@achristensen07 achristensen07 force-pushed the eng/Share-more-code-between-local-and-remote-postMessage branch from 2d93a07 to 8e143d6 Compare March 30, 2023 22:14
@achristensen07 achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 31, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Share-more-code-between-local-and-remote-postMessage branch from 8e143d6 to d715c9f Compare March 31, 2023 20:46
https://bugs.webkit.org/show_bug.cgi?id=254773

Reviewed by Chris Dumez.

Share the shape all the way down to the IDL.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::createTargetOriginForPostMessage):
* Source/WebCore/page/DOMWindow.h:
(WebCore::DOMWindow::identifier const):
* Source/WebCore/page/DOMWindow.idl: Copied from Source/WebCore/page/DOMWindow.h.
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::postMessage):
* Source/WebCore/page/LocalDOMWindow.h:
(WebCore::WindowPostMessageOptions::WindowPostMessageOptions): Deleted.
* Source/WebCore/page/LocalDOMWindow.idl:
* Source/WebCore/page/RemoteDOMWindow.cpp:
(WebCore::RemoteDOMWindow::postMessage):
* Source/WebCore/page/RemoteDOMWindow.h:
* Source/WebCore/page/RemoteDOMWindow.idl:
* Source/WebCore/page/WindowPostMessageOptions.h: Copied from Source/WebCore/page/DOMWindow.h.
(WebCore::WindowPostMessageOptions::WindowPostMessageOptions):
* Source/WebCore/page/WindowPostMessageOptions.idl: Copied from Source/WebCore/page/DOMWindow.h.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/262437@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Share-more-code-between-local-and-remote-postMessage branch from d715c9f to 3d36d22 Compare March 31, 2023 20:49
@webkit-commit-queue
Copy link
Collaborator

Committed 262437@main (3d36d22): https://commits.webkit.org/262437@main

Reviewed commits have been landed. Closing PR #12201 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3d36d22 into WebKit:main Mar 31, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants