-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share more code between local and remote postMessage #12201
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Share-more-code-between-local-and-remote-postMessage
Mar 31, 2023
Merged
Share more code between local and remote postMessage #12201
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Share-more-code-between-local-and-remote-postMessage
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
label
Mar 30, 2023
EWS run on previous version of this PR (hash 2d93a07) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Mar 30, 2023
achristensen07
force-pushed
the
eng/Share-more-code-between-local-and-remote-postMessage
branch
from
March 30, 2023 22:14
2d93a07
to
8e143d6
Compare
EWS run on current version of this PR (hash 8e143d6) |
achristensen07
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Mar 31, 2023
cdumez
approved these changes
Mar 31, 2023
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Mar 31, 2023
webkit-commit-queue
force-pushed
the
eng/Share-more-code-between-local-and-remote-postMessage
branch
from
March 31, 2023 20:46
8e143d6
to
d715c9f
Compare
https://bugs.webkit.org/show_bug.cgi?id=254773 Reviewed by Chris Dumez. Share the shape all the way down to the IDL. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::createTargetOriginForPostMessage): * Source/WebCore/page/DOMWindow.h: (WebCore::DOMWindow::identifier const): * Source/WebCore/page/DOMWindow.idl: Copied from Source/WebCore/page/DOMWindow.h. * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::postMessage): * Source/WebCore/page/LocalDOMWindow.h: (WebCore::WindowPostMessageOptions::WindowPostMessageOptions): Deleted. * Source/WebCore/page/LocalDOMWindow.idl: * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::postMessage): * Source/WebCore/page/RemoteDOMWindow.h: * Source/WebCore/page/RemoteDOMWindow.idl: * Source/WebCore/page/WindowPostMessageOptions.h: Copied from Source/WebCore/page/DOMWindow.h. (WebCore::WindowPostMessageOptions::WindowPostMessageOptions): * Source/WebCore/page/WindowPostMessageOptions.idl: Copied from Source/WebCore/page/DOMWindow.h. * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/262437@main
webkit-commit-queue
force-pushed
the
eng/Share-more-code-between-local-and-remote-postMessage
branch
from
March 31, 2023 20:49
d715c9f
to
3d36d22
Compare
Committed 262437@main (3d36d22): https://commits.webkit.org/262437@main Reviewed commits have been landed. Closing PR #12201 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3d36d22
8e143d6