[MotionMark] Live version of 4 tests just show a 403 Access Denied page #12213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
the
Layout and Rendering
|
EWS run on previous version of this PR (hash b47aa4c)
|
litherum
force-pushed
the
eng/MotionMark-Live-version-of-4-tests-just-show-a-403-Access-Denied-page
branch
from
b47aa4c
to
cb4340e
Compare
aproskuryakov
approved these changes
Mar 30, 2023
| @@ -49,7 +49,7 @@ BouncingCanvasImagesStage = Utilities.createSubclass(BouncingCanvasParticlesStag | |||
| initialize: function(benchmark, options) | |||
| { | |||
| BouncingCanvasParticlesStage.prototype.initialize.call(this, benchmark, options); | |||
| var imageSrc = options["imageSrc"] || "resources/yin-yang.svg"; | |||
| var imageSrc = options["imageSrc"] || "../resources/yin-yang.svg"; | |||
There was a problem hiding this comment.
Does this actually work? Because there's still a ../. Or is that OK because it's not in query any more?
There was a problem hiding this comment.
It does work. I've worked with Ling to run a test version of the same server, and verified that it does, in fact, fix the problem. The problem doesn't seem to be relative paths themselves, but just when ../ paths appear inside query parameters.
|
EWS run on current version of this PR (hash cb4340e)
|
https://bugs.webkit.org/show_bug.cgi?id=254782 rdar://107208247 Reviewed by Alexey Proskuryakov. Apparently, the firewall that the live MotionMark site is behind doesn't like it when paths that include the "../" string are part of query parameters in URLs. Luckily, MotionMark is already set up to do the right thing when the query parameter is omitted, so this patch just deletes those query parameters and uses the test-specific logic to fall back to the correct string anyway. * Websites/browserbench.org/MotionMark1.2/resources/debug-runner/tests.js: * Websites/browserbench.org/MotionMark1.2/tests/bouncing-particles/resources/bouncing-canvas-images.js: (BouncingCanvasParticlesStage.call.initialize): * Websites/browserbench.org/MotionMark1.2/tests/bouncing-particles/resources/bouncing-svg-images.js: (BouncingSvgParticlesStage.call.initialize): Canonical link: https://commits.webkit.org/262382@main
webkit-commit-queue
force-pushed
the
eng/MotionMark-Live-version-of-4-tests-just-show-a-403-Access-Denied-page
branch
from
cb4340e
to
7e8331b
Compare
|
Committed 262382@main (7e8331b): https://commits.webkit.org/262382@main Reviewed commits have been landed. Closing PR #12213 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
litherum
deleted the
eng/MotionMark-Live-version-of-4-tests-just-show-a-403-Access-Denied-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7e8331b
cb4340e
🛠 wpe🛠 wincairo🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🛠 gtk🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch