New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generateThreadSafe for RenderingResourceIdentifier. #12226
Use generateThreadSafe for RenderingResourceIdentifier. #12226
Conversation
EWS run on previous version of this PR (hash 701ff01) |
Would be nice to give an example of an off-main-thread call site. Offscreen canvas only, or something else? |
701ff01
to
bcfb7b6
Compare
EWS run on current version of this PR (hash bcfb7b6) |
https://bugs.webkit.org/show_bug.cgi?id=254796 <rdar://105752952> Reviewed by Simon Fraser. We can allocate ImageBuffers from a worker thread, so we need to use the thread safe allocator for all RenderingResourceIdentifiers. * Source/WebCore/platform/graphics/DecomposedGlyphs.h: * Source/WebCore/platform/graphics/Font.cpp: (WebCore::Font::renderingResourceIdentifier const): * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/platform/graphics/NativeImage.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/262486@main
bcfb7b6
to
3050026
Compare
Committed 262486@main (3050026): https://commits.webkit.org/262486@main Reviewed commits have been landed. Closing PR #12226 and removing active labels. |
3050026
bcfb7b6
π§ͺ api-macπ§ͺ gtk-wk2π§ͺ api-gtk