Add console logging message to missing or late showNotification calls in service worker #12236

youennf · 2023-03-31T15:02:10Z

`9eb7504`

Add console logging message to missing or late showNotification calls in service worker
https://bugs.webkit.org/show_bug.cgi?id=254811
rdar://problem/107471641

Reviewed by Ben Nham.

Add console log messages in case no showNotification is called during the lifetime of the push event.
Add console log messages in case a showNotification is called slightly too late after the end of the push event.

Add test API to be able to recover these console messages for WTR and related internals API.
Covered by added test.

* LayoutTests/http/wpt/service-workers/push-console-messages-no-showNotification.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-no-showNotification.https.html: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-async.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-async.https.html: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-late.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-late.https.html: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-sync.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-sync.https.html: Added.
* LayoutTests/http/wpt/service-workers/push-console-messages-worker.js: Added.
(async doPush):
(async doTest):
* LayoutTests/http/wpt/service-workers/push-console-messages.js: Added.
(promise_test.async test):
(async doTest):
* LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-no-showNotification.https-expected.txt: Added.
* LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-async.https-expected.txt: Added.
* LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-late.https-expected.txt: Added.
* LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-sync.https-expected.txt: Added.
* Source/WebCore/testing/ServiceWorkerInternals.cpp:
(WebCore::ServiceWorkerInternals::enableConsoleMessageReporting):
(WebCore::logReportedConsoleMessage):
* Source/WebCore/testing/ServiceWorkerInternals.h:
* Source/WebCore/testing/ServiceWorkerInternals.idl:
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::dispatchPushEvent):
(WebCore::ServiceWorkerGlobalScope::didFirePushEventRecently const):
(WebCore::ServiceWorkerGlobalScope::addConsoleMessage):
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.h:
* Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
* Source/WebCore/workers/service/context/SWContextManager.h:
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFirePushEvent):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::reportConsoleMessage):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::reportConsoleMessage):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::reportServiceWorkerConsoleMessage):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h:
(WebKit::WebsiteDataStoreClient::reportServiceWorkerConsoleMessage):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::reportConsoleMessage):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerOpenWindowWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::receivedServiceWorkerConsoleMessage):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
(-[TestWebsiteDataStoreDelegate websiteDataStore:reportServiceWorkerConsoleMessage:]):

Canonical link: https://commits.webkit.org/262584@main

1bd089c

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-31T15:04:24Z

EWS run on previous version of this PR (hash 4706b9c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

bnham

LGTM. I do wonder if we should try to be more specific in the error message and provide guidance about calling waitUntil on the push event,since that seems to be a common issue devs are running into.

bnham · 2023-03-31T18:00:38Z

Source/WebCore/workers/service/ServiceWorkerRegistration.cpp

@@ -319,6 +316,12 @@ void ServiceWorkerRegistration::showNotification(ScriptExecutionContext& context
            auto& jsPromise = *JSC::jsCast<JSC::JSPromise*>(promise->promise());
            pushEvent->waitUntil(DOMPromise::create(globalObject, jsPromise));
        }
+
+        if (!serviceWorkerGlobalScope->hasPendingSilentPushEvent() && serviceWorkerGlobalScope->didFirePushEventRecently())
+            serviceWorkerGlobalScope->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "showNotification was called outside of push event lifetime"_s, 0);


Should this message also mention that you may want to pass the promised returned by showNotification to the push event's waitUntil to appropriately extend the lifetime of the push event?

This is wordy, but I think we need something like: "This service worker showed a notification outside of the lifetime of a recent push event. This may cause the push event to be spuriously marked as a silent push. To fix this, consider passing the promise returned by showNotification to the push event's waitUntil. This will extend the lifetime of the push event to encompass the lifetime of the notification."

An alternative is to put the wordy explanation on the web somewhere, and have this error message link to the wordy explanation. I've seen Chrome do that in console messages but I'm not sure if we do that anywhere.

OK, I'll add a mention to PushEvent.waitUntil, trying to stick with a short version.

bnham · 2023-03-31T18:06:13Z

Source/WebCore/workers/service/ServiceWorkerRegistration.cpp

-    if (context.isServiceWorkerGlobalScope())
-        downcast<ServiceWorkerGlobalScope>(context).setHasPendingSilentPushEvent(false);
-


I think we originally put this check here defensively so that the web developer gets credit for trying to show a notification even if creating the notification creation fails for some reason. But looking through Notification::createForServiceWorker, this basically shouldn't happen except in edge cases (e.g. if the web dev tries to pass in a too-large data property into the Notification constructor). So I guess it's okay to move this down a few lines to where you've moved it.

Right, I think we should move it, see for instance rdar://107461729

bnham · 2023-03-31T18:13:56Z

Source/WebCore/workers/service/context/ServiceWorkerThread.cpp

@@ -246,6 +246,9 @@ void ServiceWorkerThread::queueTaskToFirePushEvent(std::optional<Vector<uint8_t>
            }

            bool showedNotification = !serviceWorkerGlobalScope->hasPendingSilentPushEvent();
+            serviceWorkerGlobalScope->setHasPendingSilentPushEvent(false);
+            if (!showedNotification)
+                serviceWorkerGlobalScope->addConsoleMessage(MessageSource::Storage, MessageLevel::Error, "Push event ended without showing any notification"_s, 0);


I wonder if we should be explicit about the consequences here. Like "Push event ended without showing any notification. After three such silent push events, the browser will remove your push subscription."

I'll mention the risk of the push subscription removal, but not too precise (I do not want to change the message if we change the rule).

webkit-early-warning-system · 2023-04-02T04:13:29Z

EWS run on previous version of this PR (hash 8239371)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-02T16:40:58Z

EWS run on previous version of this PR (hash e669b60)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-03T17:12:48Z

EWS run on previous version of this PR (hash 2165d6b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-04T00:12:03Z

EWS run on previous version of this PR (hash 56fbfa6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-04T13:43:50Z

EWS run on previous version of this PR (hash cfb2153)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-04T16:33:36Z

EWS run on current version of this PR (hash 1bd089c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

… in service worker https://bugs.webkit.org/show_bug.cgi?id=254811 rdar://problem/107471641 Reviewed by Ben Nham. Add console log messages in case no showNotification is called during the lifetime of the push event. Add console log messages in case a showNotification is called slightly too late after the end of the push event. Add test API to be able to recover these console messages for WTR and related internals API. Covered by added test. * LayoutTests/http/wpt/service-workers/push-console-messages-no-showNotification.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-no-showNotification.https.html: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-async.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-async.https.html: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-late.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-late.https.html: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-sync.https-expected.txt: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-showNotification-sync.https.html: Added. * LayoutTests/http/wpt/service-workers/push-console-messages-worker.js: Added. (async doPush): (async doTest): * LayoutTests/http/wpt/service-workers/push-console-messages.js: Added. (promise_test.async test): (async doTest): * LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-no-showNotification.https-expected.txt: Added. * LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-async.https-expected.txt: Added. * LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-late.https-expected.txt: Added. * LayoutTests/platform/glib/http/wpt/service-workers/push-console-messages-showNotification-sync.https-expected.txt: Added. * Source/WebCore/testing/ServiceWorkerInternals.cpp: (WebCore::ServiceWorkerInternals::enableConsoleMessageReporting): (WebCore::logReportedConsoleMessage): * Source/WebCore/testing/ServiceWorkerInternals.h: * Source/WebCore/testing/ServiceWorkerInternals.idl: * Source/WebCore/workers/WorkerGlobalScope.h: * Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp: (WebCore::ServiceWorkerGlobalScope::dispatchPushEvent): (WebCore::ServiceWorkerGlobalScope::didFirePushEventRecently const): (WebCore::ServiceWorkerGlobalScope::addConsoleMessage): * Source/WebCore/workers/service/ServiceWorkerGlobalScope.h: * Source/WebCore/workers/service/ServiceWorkerRegistration.cpp: (WebCore::ServiceWorkerRegistration::showNotification): * Source/WebCore/workers/service/context/SWContextManager.h: * Source/WebCore/workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::queueTaskToFirePushEvent): * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::reportConsoleMessage): * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::reportConsoleMessage): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::reportServiceWorkerConsoleMessage): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::reportServiceWorkerConsoleMessage): * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::reportConsoleMessage): * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: (-[ServiceWorkerOpenWindowWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::receivedServiceWorkerConsoleMessage): * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate websiteDataStore:reportServiceWorkerConsoleMessage:]): Canonical link: https://commits.webkit.org/262584@main

webkit-commit-queue · 2023-04-04T18:37:21Z

Committed 262584@main (9eb7504): https://commits.webkit.org/262584@main

Reviewed commits have been landed. Closing PR #12236 and removing active labels.

youennf requested review from cdumez and JonWBedard as code owners March 31, 2023 15:02

youennf self-assigned this Mar 31, 2023

youennf added the Service Workers Component for Service Workers bugs. label Mar 31, 2023

youennf requested review from beidson and bnham March 31, 2023 15:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 31, 2023

bnham approved these changes Mar 31, 2023

View reviewed changes

bnham reviewed Mar 31, 2023

View reviewed changes

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from 4706b9c to 8239371 Compare April 2, 2023 04:13

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from 8239371 to e669b60 Compare April 2, 2023 16:39

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from e669b60 to 2165d6b Compare April 3, 2023 17:10

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from 2165d6b to 56fbfa6 Compare April 4, 2023 00:11

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from 56fbfa6 to cfb2153 Compare April 4, 2023 13:40

youennf removed the merging-blocked Applied to prevent a change from being merged label Apr 4, 2023

youennf force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from cfb2153 to 1bd089c Compare April 4, 2023 16:33

youennf added the merge-queue Applied to send a pull request to merge-queue label Apr 4, 2023

webkit-commit-queue force-pushed the eng/Add-console-logging-message-to-missing-or-late-shwoNotification-calls-in-service-worker branch from 1bd089c to 9eb7504 Compare April 4, 2023 18:37

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 4, 2023

webkit-commit-queue merged commit 9eb7504 into WebKit:main Apr 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add console logging message to missing or late showNotification calls in service worker #12236

Add console logging message to missing or late showNotification calls in service worker #12236

youennf commented Mar 31, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 31, 2023 •

edited

bnham left a comment

bnham Mar 31, 2023 •

edited

youennf Apr 1, 2023

bnham Mar 31, 2023

youennf Apr 1, 2023

bnham Mar 31, 2023

youennf Apr 1, 2023

webkit-early-warning-system commented Apr 2, 2023 •

edited

webkit-early-warning-system commented Apr 2, 2023 •

edited

webkit-early-warning-system commented Apr 3, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited

webkit-commit-queue commented Apr 4, 2023

		if (context.isServiceWorkerGlobalScope())
		downcast<ServiceWorkerGlobalScope>(context).setHasPendingSilentPushEvent(false);

Add console logging message to missing or late showNotification calls in service worker #12236

Add console logging message to missing or late showNotification calls in service worker #12236

Conversation

youennf commented Mar 31, 2023 • edited by webkit-early-warning-system

9eb7504

webkit-early-warning-system commented Mar 31, 2023 • edited

bnham left a comment

Choose a reason for hiding this comment

bnham Mar 31, 2023 • edited

Choose a reason for hiding this comment

youennf Apr 1, 2023

Choose a reason for hiding this comment

bnham Mar 31, 2023

Choose a reason for hiding this comment

youennf Apr 1, 2023

Choose a reason for hiding this comment

bnham Mar 31, 2023

Choose a reason for hiding this comment

youennf Apr 1, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Apr 2, 2023 • edited

webkit-early-warning-system commented Apr 2, 2023 • edited

webkit-early-warning-system commented Apr 3, 2023 • edited

webkit-early-warning-system commented Apr 4, 2023 • edited

webkit-early-warning-system commented Apr 4, 2023 • edited

webkit-early-warning-system commented Apr 4, 2023 • edited

webkit-commit-queue commented Apr 4, 2023

youennf commented Mar 31, 2023 •

edited by webkit-early-warning-system

`9eb7504`

webkit-early-warning-system commented Mar 31, 2023 •

edited

bnham Mar 31, 2023 •

edited

webkit-early-warning-system commented Apr 2, 2023 •

edited

webkit-early-warning-system commented Apr 2, 2023 •

edited

webkit-early-warning-system commented Apr 3, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited

webkit-early-warning-system commented Apr 4, 2023 •

edited