Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is consistently timing out on release #1225

Merged
merged 0 commits into from Jun 2, 2022

Conversation

szewai
Copy link
Contributor

@szewai szewai commented Jun 1, 2022

ecaa543

[iOS] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is consistently timing out on release
https://bugs.webkit.org/show_bug.cgi?id=240886

Reviewed by Chris Dumez.

Modify the test to make it less flaky and easier to debug. The changes including:
1. "Continue" message is sent from web page after first operation completes, instead of database is opened, so we can
make sure transaction is started before _sendNetworkProcessWillSuspendImminently.
2. Call _sendNetworkProcessDidResume after first transaction is aborted ("Abort" message is received), so we can make
sure network process has handled suspend message.
3. The test pages create only two different transactions: the first is a long transaction, which keeps running until it
gets aborted by suspension; the second is a short transaction, which is only used to prove that not all transactions
will be aborted by suspension. We used to create 10 identical transactions and it could be any of them gets aborted.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(TEST):

Canonical link: https://commits.webkit.org/251208@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@szewai szewai self-assigned this Jun 1, 2022
@szewai szewai added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. Safari 13 labels Jun 1, 2022
@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Jun 2, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit ecaa543 into WebKit:main Jun 2, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295117 (251208@main): https://commits.webkit.org/251208@main

Reviewed commits have been landed. Closing PR #1225 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 2, 2022
@szewai szewai deleted the eng/bug_240886 branch June 2, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
3 participants