Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTMLFastPathParser::scanTagName() to return an ElementName #12270

Merged
merged 1 commit into from Apr 1, 2023
Merged

Update HTMLFastPathParser::scanTagName() to return an ElementName #12270

merged 1 commit into from Apr 1, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 1, 2023 •
edited by webkit-early-warning-system

8e6de78

Update HTMLFastPathParser::scanTagName() to return an ElementName
https://bugs.webkit.org/show_bug.cgi?id=254857

Reviewed by Darin Adler.

Update HTMLFastPathParser::scanTagName() to return an ElementName enum instead
of a Span<Character>. This simplifies the logic in the HTML fast parser and is
slightly more efficient.

* Source/WebCore/dom/make_names.pl:
(printElementNameHeaderFile):
(printElementNameCppFile):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanTagName):
(WebCore::HTMLFastPathParser::parseSpecificElements):
(WebCore::HTMLFastPathParser::parseElement):
(WebCore::onlyContainsLowercaseASCIILetters): Deleted.
(WebCore::tagNameHash): Deleted.

Canonical link: https://commits.webkit.org/262484@main

1f6983c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Apr 1, 2023
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 1, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 7fb9a90)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 1, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Apr 1, 2023
@cdumez cdumez marked this pull request as ready for review April 1, 2023 07:03
@cdumez cdumez requested a review from rniwa as a code owner April 1, 2023 07:03
darinadler
darinadler approved these changes Apr 1, 2023
View reviewed changes
Source/WebCore/dom/make_names.pl Outdated
Comment on lines 1051 to 1052
print F "ElementName findHTMLElementNameFromBuffer(Span<const LChar>);\n";
print F "ElementName findHTMLElementNameFromBuffer(Span<const UChar>);\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these just be findHTMLElementName? I don’t think we need “from buffer” in the name.

Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp Outdated
@@ -845,16 +815,16 @@ class HTMLFastPathParser {

template<class... Tags> RefPtr<Element> parseSpecificElements()
{
CharSpan tagName = scanTagName();
ElementName tagName = scanTagName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto

@cdumez cdumez force-pushed the 254857_scanTagName_ElementName branch from 7fb9a90 to 0958e72 Compare April 1, 2023 17:10
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 0958e72)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🛠 gtk
❌ 🧪 api-ios ❌ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🛠 tv ❌ 🧪 mac-wk2   🧪 api-gtk
❌ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 watch ❌ 🧪 mac-wk2-stress
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 1, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Apr 1, 2023
@cdumez cdumez force-pushed the 254857_scanTagName_ElementName branch from 0958e72 to 1f6983c Compare April 1, 2023 17:37
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1f6983c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2023
@cdumez
Update HTMLFastPathParser::scanTagName() to return an ElementName
8e6de78 
https://bugs.webkit.org/show_bug.cgi?id=254857

Reviewed by Darin Adler.

Update HTMLFastPathParser::scanTagName() to return an ElementName enum instead
of a Span<Character>. This simplifies the logic in the HTML fast parser and is
slightly more efficient.

* Source/WebCore/dom/make_names.pl:
(printElementNameHeaderFile):
(printElementNameCppFile):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanTagName):
(WebCore::HTMLFastPathParser::parseSpecificElements):
(WebCore::HTMLFastPathParser::parseElement):
(WebCore::onlyContainsLowercaseASCIILetters): Deleted.
(WebCore::tagNameHash): Deleted.

Canonical link: https://commits.webkit.org/262484@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262484@main (8e6de78): https://commits.webkit.org/262484@main

Reviewed commits have been landed. Closing PR #12270 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8e6de78 into WebKit:main Apr 1, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot